Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetadataSearchResult modified to be more descriptive #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twojciac
Copy link

Updated MetadataSearchResult to show the book title, author, and publishing year rather than just the title. This should improve the end user's ability to find the correct match rather than providing just the title which may have multiple results by various authors.

Updated MetadataSearchResult to show the book title, author, and publishing year rather than just the title.  This should improve the end user's ability to find the correct match rather than providing just the title which may have multiple results by various authors.
@twojciac twojciac changed the title Update __init__.py MetadataSearchResult modified to be more descriptive May 12, 2021
@djdembeck
Copy link

This would be super helpful!

@jt196
Copy link

jt196 commented Sep 21, 2021

Agreed - at the moment you have to cycle through the choices. Narrator would be helpful as well.

@jt196
Copy link

jt196 commented Sep 21, 2021

@twojciac just having a little play around with this code. The problem with how you've written it (or how the Audiobook metadata agent works) is that when you save the metadata, the descriptive title is saved instead of the book title. So you end up with the description string description = '\"%s\" by %s [%s]' % (r['title'], r['artist'], r['year']) instead of just r['title'] in the name of the book.

*EDIT: I think this may have been as I hadn't removed the original results.Append(MetadataSearchResult(... line, just testing it and it seems to work.

@jt196
Copy link

jt196 commented Sep 21, 2021

Don't have time to faff around with pulling etc, but if you want to get the narrator to display you should replace the line:

info.append({'id': itemId, 'title': title, 'year': year, 'date': date, 'score': score, 'thumb': thumb, 'artist' : author})
with
info.append({'id': itemId, 'title': title, 'year': year, 'date': date, 'score': score, 'thumb': thumb, 'artist' : author, 'narrator': narrator})

and the line:
description = '\"%s\" by %s [%s]' % (r['title'], r['artist'], r['year'])
with
description = '\"%s\" by %s [%s] narr: %s' % (r['title'], r['artist'], r['year'], r['narrator'])

@djdembeck
Copy link

This feature has already been implemented in the re-written fork: https://github.com/seanap/Audiobooks.bundle

@jt196
Copy link

jt196 commented Sep 21, 2021

Apologies, wasn't aware there was an active fork. Will chuck in a feature request then.

@jt196
Copy link

jt196 commented Sep 21, 2021

@djdembeck added a new feature request and the appropriate code for the rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants