Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add old_openssl port group #4297

Merged
merged 4 commits into from
May 21, 2019
Merged

Add old_openssl port group #4297

merged 4 commits into from
May 21, 2019

Conversation

yan12125
Copy link
Contributor

Description

They are not compatible with OpenSSL 1.1. For example, php56-openssl
fails with:

/opt/local/var/macports/build/_Users_yen_var_syncthing_Projects_macports-ports_lang_php/php56-openssl/work/php-5.6.40/ext/openssl/openssl.c:1904:15: error: incomplete definition of type 'struct X509_extension_st'
        p = extension->value->data;
            ~~~~~~~~~^

All ports tested with the following PHP script:

Closes: https://trac.macports.org/ticket/58464

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.4 18E226
Xcode 10.2.1 10E1001

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install? only php*-openssl ports
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port php.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: requires approval labels May 11, 2019
@yan12125 yan12125 mentioned this pull request May 11, 2019
Merged
25 tasks
cjones051073
cjones051073 reviewed May 11, 2019
View reviewed changes
lang/php/Portfile Outdated Show resolved Hide resolved
@macportsbot
Copy link

Travis Build #6407 Errored.

Lint results 
--->  Verifying Portfile for php
--->  0 errors and 0 warnings found.

Port php73 success on xcode10.2. Log
Port php success on xcode10.2. Log
Port php52 success on xcode10.2. Log
Port php52-apache2handler fail on xcode10.2. Log
Port php52-calendar success on xcode10.2. Log
Port php52-cgi success on xcode10.2. Log
Port php52-curl success on xcode10.2. Log
Port php52-dba success on xcode10.2. Log
Port php52-exif success on xcode10.2. Log
Port php52-ftp success on xcode10.2. Log
Port php52-gd success on xcode10.2. Log
Port php52-gettext success on xcode10.2. Log
Port php52-gmp success on xcode10.2. Log
Port php52-iconv success on xcode10.2. Log
Port php52-imap success on xcode10.2. Log
Port php52-ipc success on xcode10.2. Log
Port php73 success on xcode9.4. Log
Port php success on xcode9.4. Log
Port php52 success on xcode9.4. Log
Port php52-apache2handler fail on xcode9.4. Log
Port php52-calendar success on xcode9.4. Log
Port php52-cgi success on xcode9.4. Log
Port php52-curl success on xcode9.4. Log
Port php52-dba success on xcode9.4. Log
Port php52-exif success on xcode9.4. Log
Port php52-ftp success on xcode9.4. Log
Port php52-gd success on xcode9.4. Log
Port php52-gettext success on xcode9.4. Log
Port php52-gmp success on xcode9.4. Log
Port php52-iconv success on xcode9.4. Log
Port php52-imap success on xcode9.4. Log
Port php52-ipc success on xcode9.4. Log
Port php52-ldap success on xcode9.4. Log
Port php52-mbstring success on xcode9.4. Log
Port php52-mcrypt success on xcode9.4. Log
Port php73 success on xcode8.3. Log
Port php success on xcode8.3. Log
Port php52 success on xcode8.3. Log
Port php52-apache2handler fail on xcode8.3. Log
Port php52-calendar success on xcode8.3. Log
Port php52-cgi success on xcode8.3. Log
Port php52-curl success on xcode8.3. Log
Port php52-dba success on xcode8.3. Log
Port php52-exif success on xcode8.3. Log
Port php52-ftp success on xcode8.3. Log
Port php52-gd success on xcode8.3. Log
Port php52-gettext success on xcode8.3. Log
Port php52-gmp success on xcode8.3. Log
Port php52-iconv success on xcode8.3. Log
Port php52-imap success on xcode8.3. Log
Port php52-ipc success on xcode8.3. Log
Port php52-ldap success on xcode8.3. Log
Port php52-mbstring success on xcode8.3. Log
Port php52-mcrypt success on xcode8.3. Log
Port php52-mssql success on xcode8.3. Log
Port php52-mysql success on xcode8.3. Log
Port php52-odbc success on xcode8.3. Log
Port php52-openssl success on xcode8.3. Log
Port php73 success on xcode7.3. Log
Port php success on xcode7.3. Log
Port php52 success on xcode7.3. Log
Port php52-apache2handler fail on xcode7.3. Log
Port php52-calendar success on xcode7.3. Log
Port php52-cgi success on xcode7.3. Log
Port php52-curl success on xcode7.3. Log
Port php52-dba success on xcode7.3. Log
Port php52-exif success on xcode7.3. Log
Port php52-ftp success on xcode7.3. Log
Port php52-gd success on xcode7.3. Log
Port php52-gettext success on xcode7.3. Log
Port php52-gmp success on xcode7.3. Log
Port php52-iconv success on xcode7.3. Log
Port php52-imap success on xcode7.3. Log
Port php52-ipc success on xcode7.3. Log
Port php52-ldap success on xcode7.3. Log
Port php52-mbstring success on xcode7.3. Log
Port php52-mcrypt success on xcode7.3. Log
Port php52-mssql success on xcode7.3. Log
Port php52-mysql success on xcode7.3. Log
Port php52-odbc success on xcode7.3. Log
Port php52-openssl success on xcode7.3. Log
Port php52-oracle success on xcode7.3. Log
Port php52-pcntl success on xcode7.3. Log
Port php52-posix success on xcode7.3. Log
Port php52-postgresql success on xcode7.3. Log
Port php52-pspell success on xcode7.3. Log

The build timed out.

@yan12125 yan12125 added the wip Work in progress label May 16, 2019
@yan12125 yan12125 changed the title php5{2,3,4,5,6}-openssl: use openssl10 Add openssl port group May 17, 2019
@yan12125
Copy link
Contributor Author

Have you had chance to look into an ssl portgroup ?

Here you go. Takes a little longer time than I've thought :)

@macportsbot retry

@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port php.
@kimuraw for port ruby.

@yan12125 yan12125 removed the wip Work in progress label May 17, 2019
@macportsbot
Copy link

Travis Build #6509 Errored.

Lint results 
--->  Verifying Portfile for php
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for python26
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ruby
--->  0 errors and 0 warnings found.

Port php73 success on xcode10.2. Log
Port php success on xcode10.2. Log
Port php52 success on xcode10.2. Log
Port php52-apache2handler fail on xcode10.2. Log
Port php52-calendar success on xcode10.2. Log
Port php52-cgi success on xcode10.2. Log
Port php52-curl success on xcode10.2. Log
Port php52-dba success on xcode10.2. Log
Port php52-exif success on xcode10.2. Log
Port php52-ftp success on xcode10.2. Log
Port php52-gd success on xcode10.2. Log
Port php52-gettext success on xcode10.2. Log
Port php52-gmp success on xcode10.2. Log
Port php73 success on xcode9.4. Log
Port php success on xcode9.4. Log
Port php52 success on xcode9.4. Log
Port php52-apache2handler fail on xcode9.4. Log
Port php52-calendar success on xcode9.4. Log
Port php52-cgi success on xcode9.4. Log
Port php52-curl success on xcode9.4. Log
Port php52-dba success on xcode9.4. Log
Port php52-exif success on xcode9.4. Log
Port php52-ftp success on xcode9.4. Log
Port php52-gd success on xcode9.4. Log
Port php52-gettext success on xcode9.4. Log
Port php52-gmp success on xcode9.4. Log
Port php52-iconv success on xcode9.4. Log
Port php52-imap success on xcode9.4. Log
Port php52-ipc success on xcode9.4. Log
Port php73 success on xcode8.3. Log
Port php success on xcode8.3. Log
Port php52 success on xcode8.3. Log
Port php52-apache2handler fail on xcode8.3. Log
Port php52-calendar success on xcode8.3. Log
Port php52-cgi success on xcode8.3. Log
Port php52-curl success on xcode8.3. Log
Port php52-dba success on xcode8.3. Log
Port php52-exif success on xcode8.3. Log
Port php52-ftp success on xcode8.3. Log
Port php52-gd success on xcode8.3. Log
Port php52-gettext success on xcode8.3. Log
Port php52-gmp success on xcode8.3. Log
Port php52-iconv success on xcode8.3. Log
Port php52-imap success on xcode8.3. Log
Port php52-ipc success on xcode8.3. Log
Port php52-ldap success on xcode8.3. Log
Port php52-mbstring success on xcode8.3. Log
Port php52-mcrypt success on xcode8.3. Log
Port php52-mssql success on xcode8.3. Log
Port php52-mysql success on xcode8.3. Log
Port php73 success on xcode7.3. Log
Port php success on xcode7.3. Log
Port php52 success on xcode7.3. Log
Port php52-apache2handler fail on xcode7.3. Log
Port php52-calendar success on xcode7.3. Log
Port php52-cgi success on xcode7.3. Log
Port php52-curl success on xcode7.3. Log
Port php52-dba success on xcode7.3. Log
Port php52-exif success on xcode7.3. Log
Port php52-ftp success on xcode7.3. Log
Port php52-gd success on xcode7.3. Log
Port php52-gettext success on xcode7.3. Log
Port php52-gmp success on xcode7.3. Log
Port php52-iconv success on xcode7.3. Log
Port php52-imap success on xcode7.3. Log
Port php52-ipc success on xcode7.3. Log
Port php52-ldap success on xcode7.3. Log
Port php52-mbstring success on xcode7.3. Log
Port php52-mcrypt success on xcode7.3. Log
Port php52-mssql success on xcode7.3. Log
Port php52-mysql success on xcode7.3. Log
Port php52-odbc success on xcode7.3. Log
Port php52-openssl success on xcode7.3. Log
Port php52-oracle's dependencies fail on xcode7.3. Log
Port php52-pcntl success on xcode7.3. Log
Port php52-posix success on xcode7.3. Log

The build timed out.

@cjones051073
Copy link
Member

Have you had chance to look into an ssl portgroup ?

Here you go. Takes a little longer time than I've thought :)

@macportsbot retry

Looks like a good start. Many thanks.

One comment I would have is I would make it support 1.1 as well as 1.0, and provide an option for the port using it to select which to use. It just seems a little inconsistent to me to only use it for 1.0. If it where used for 1.1 (and future releases) as well I think it would improve maintainability going forward.

@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port php.
@kimuraw for port ruby.

@yan12125
Copy link
Contributor Author

One comment I would have is I would make it support 1.1 as well as 1.0

I prefer to keep ports using the latest openssl free of bothering with another port group. Once OpenSSL 3.0 is out, it should be easy to add 1.1 support.

provide an option for the port using it to select which to use

I think the option openssl.branch is what you're looking for?

@cjones051073
Copy link
Member

One comment I would have is I would make it support 1.1 as well as 1.0

I prefer to keep ports using the latest openssl free of bothering with another port group. Once OpenSSL 3.0 is out, it should be easy to add 1.1 support.

Thats ok, but then I would propose renaming the PG to make it clearer its for supporting legacy openssl versions.

provide an option for the port using it to select which to use

I think the option openssl.branch is what you're looking for?

Yes, i guess it is ;)

@yan12125
Copy link
Contributor Author

How about calling it old_openssl?

@cjones051073
Copy link
Member

How about calling it old_openssl?

Personally i would use legacy instead of old, but either is ok.

Chih-Hsuan Yen added 4 commits May 19, 2019 00:23
old_openssl: new port group for easing usage of the older openssl ports
4c10439 
This is a step in OpenSSL 1.1 migration.

Ref: #3822
Ref: https://trac.macports.org/ticket/52101
php5{2,3,4,5,6}-openssl: use openssl 1.0 via the old_openssl port group
2314d16 
They are not compatible with OpenSSL 1.1. For example, php56-openssl
fails with:

/opt/local/var/macports/build/_Users_yen_var_syncthing_Projects_macports-ports_lang_php/php56-openssl/work/php-5.6.40/ext/openssl.c:1904:15: error: incomplete definition of type 'struct X509_extension_st'
        p = extension->value->data;
            ~~~~~~~~~^

All ports tested with the following PHP script:

<?php
echo file_get_contents('https://httpbin.org/ip');
?>

Closes: https://trac.macports.org/ticket/58464
python26: use old_openssl port group
5292001 
No revbump as the result binary should remain the same
ruby: use old_openssl port group
8e8ffcd
@yan12125
Copy link
Contributor Author

Done renaming! Actually I've once considered "legacy" but the word gives me a feeling that openssl 1.0 is no longer supported upstream ;)

@macportsbot
Copy link

Travis Build #6533 Errored.

Lint results 
--->  Verifying Portfile for php
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for python26
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ruby
--->  0 errors and 0 warnings found.

Port php73 success on xcode10.2. Log
Port php success on xcode10.2. Log
Port php52 success on xcode10.2. Log
Port php52-apache2handler fail on xcode10.2. Log
Port php52-calendar success on xcode10.2. Log
Port php52-cgi success on xcode10.2. Log
Port php52-curl success on xcode10.2. Log
Port php52-dba success on xcode10.2. Log
Port php52-exif success on xcode10.2. Log
Port php52-ftp success on xcode10.2. Log
Port php52-gd success on xcode10.2. Log
Port php52-gettext success on xcode10.2. Log
Port php52-gmp success on xcode10.2. Log
Port php52-iconv success on xcode10.2. Log
Port php52-imap success on xcode10.2. Log
Port php52-ipc success on xcode10.2. Log
Port php73 success on xcode9.4. Log
Port php success on xcode9.4. Log
Port php52 success on xcode9.4. Log
Port php52-apache2handler fail on xcode9.4. Log
Port php52-calendar success on xcode9.4. Log
Port php52-cgi success on xcode9.4. Log
Port php52-curl success on xcode9.4. Log
Port php52-dba success on xcode9.4. Log
Port php52-exif success on xcode9.4. Log
Port php52-ftp success on xcode9.4. Log
Port php52-gd success on xcode9.4. Log
Port php52-gettext success on xcode9.4. Log
Port php52-gmp success on xcode9.4. Log
Port php52-iconv success on xcode9.4. Log
Port php52-imap success on xcode9.4. Log
Port php52-ipc success on xcode9.4. Log
Port php52-ldap success on xcode9.4. Log
Port php52-mbstring success on xcode9.4. Log
Port php52-mcrypt success on xcode9.4. Log
Port php52-mssql success on xcode9.4. Log
Port php73 success on xcode8.3. Log
Port php success on xcode8.3. Log
Port php52 success on xcode8.3. Log
Port php52-apache2handler fail on xcode8.3. Log
Port php52-calendar success on xcode8.3. Log
Port php52-cgi success on xcode8.3. Log
Port php52-curl success on xcode8.3. Log
Port php52-dba success on xcode8.3. Log
Port php52-exif success on xcode8.3. Log
Port php52-ftp success on xcode8.3. Log
Port php52-gd success on xcode8.3. Log
Port php52-gettext success on xcode8.3. Log
Port php52-gmp success on xcode8.3. Log
Port php52-iconv success on xcode8.3. Log
Port php52-imap success on xcode8.3. Log
Port php52-ipc success on xcode8.3. Log
Port php52-ldap success on xcode8.3. Log
Port php52-mbstring success on xcode8.3. Log
Port php52-mcrypt success on xcode8.3. Log
Port php52-mssql success on xcode8.3. Log
Port php52-mysql success on xcode8.3. Log
Port php52-odbc success on xcode8.3. Log
Port php52-openssl success on xcode8.3. Log
Port php73 success on xcode7.3. Log
Port php success on xcode7.3. Log
Port php52 success on xcode7.3. Log
Port php52-apache2handler fail on xcode7.3. Log
Port php52-calendar success on xcode7.3. Log
Port php52-cgi success on xcode7.3. Log
Port php52-curl success on xcode7.3. Log
Port php52-dba success on xcode7.3. Log
Port php52-exif success on xcode7.3. Log
Port php52-ftp success on xcode7.3. Log
Port php52-gd success on xcode7.3. Log
Port php52-gettext success on xcode7.3. Log
Port php52-gmp success on xcode7.3. Log
Port php52-iconv success on xcode7.3. Log
Port php52-imap success on xcode7.3. Log
Port php52-ipc success on xcode7.3. Log
Port php52-ldap success on xcode7.3. Log
Port php52-mbstring success on xcode7.3. Log
Port php52-mcrypt success on xcode7.3. Log
Port php52-mssql success on xcode7.3. Log
Port php52-mysql success on xcode7.3. Log
Port php52-odbc success on xcode7.3. Log
Port php52-openssl success on xcode7.3. Log
Port php52-oracle success on xcode7.3. Log
Port php52-pcntl success on xcode7.3. Log
Port php52-posix success on xcode7.3. Log
Port php52-postgresql success on xcode7.3. Log
Port php52-pspell success on xcode7.3. Log

The build timed out.

@yan12125 yan12125 changed the title Add openssl port group Add old_openssl port group May 19, 2019
@kimuraw
Copy link
Member

kimuraw commented May 21, 2019

@yan12125 your change of port:ruby looks good to me

@yan12125
Copy link
Contributor Author

Thanks for checking it out!

Gonna merge this - all changes keep backward compatibility IMO.

And thanks for reviewing @cjones051073!

@yan12125 yan12125 merged commit 9955c9c into macports:master May 21, 2019
@yan12125 yan12125 deleted the php-openssl10 branch May 21, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjones051073 cjones051073 cjones051073 left review comments

Assignees

@kimuraw kimuraw

@ryandesign ryandesign

Labels
by: member Created by a member with commit rights maintainer: requires approval maintainer: timeout
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yan12125 @macportsbot @cjones051073 @kimuraw @ryandesign