Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs6: use bundled openssl #4259

Merged
merged 1 commit into from
May 4, 2019
Merged

nodejs6: use bundled openssl #4259

merged 1 commit into from
May 4, 2019

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented May 4, 2019

Description

This is a preparation step for OpenSSL 1.1 migration. Node.js 6 does not
build with OpenSSL 1.1:

:info:build ../src/node_crypto.h:91:40: error: invalid application of 'sizeof' to an incomplete type 'SSL_CTX' (aka 'ssl_ctx_st')

I switched to bundled openssl instead of using the openssl10 port to
lower the maintenance burden. nodejs6 is EOL'ed upstream and will be
considered to be dropped once nodejs8 works on OS X 10.6, anyway.

nodejs8 is not touched as it works with OpenSSL 1.1:

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.4 18E226
Xcode 10.2.1 10E1001

Verification

Have you

This is a preparation step for OpenSSL 1.1 migration. Node.js 6 does not
build with OpenSSL 1.1:

:info:build ../src/node_crypto.h:91:40: error: invalid application of 'sizeof' to an incomplete type 'SSL_CTX' (aka 'ssl_ctx_st')

I switched to bundled openssl instead of using the openssl10 port to
lower the maintenance burden. nodejs6 is EOL'ed upstream and will be
considered to be dropped once nodejs8 works on OS X 10.6, anyway.

Closes: https://trac.macports.org/ticket/58224
@macportsbot
Copy link

Notifying maintainers:
@ci42 for port nodejs6.

@macportsbot
Copy link

Travis Build #6318 Passed.

Lint results
--->  Verifying Portfile for nodejs6
--->  0 errors and 0 warnings found.

Port nodejs6 success on xcode10.2. Log
Port nodejs6 success on xcode9.4. Log
Port nodejs6 success on xcode8.3. Log

@ci42 ci42 merged commit dd890d2 into macports:master May 4, 2019
@yan12125 yan12125 deleted the nodejs6-bundled-openssl branch May 4, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants