Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6-qtcreator: new port #26740

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

rue-ryuzaki
Copy link
Contributor

@rue-ryuzaki rue-ryuzaki commented Nov 25, 2024

Description

Portfile has been updated for the new Qt Creator version:

  • build with cmake
  • use clang-17 from macports instead of host clang
  • remove unused patch clang16_Wenum_constexpr_conversion
  • adapt patch no_qtwebengine for cmake
  • use c++ standard 20 (defined in CMakeLists.txt)
  • update Qt Creator.app build directory for destroot
  • remove move libexec/QtProject to Resources (must be already there)
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.1 24B83 x86_64
Xcode 16.1 16B40

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port qt5-qtcreator.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Nov 25, 2024
@reneeotten
Copy link
Contributor

this doesn't seem right. You commented on another PR that the version you're updating the port here uses Qt6; so that should certainly not be called "qt5-...".
Please upsat the "qt5-qtcreator" port to the latest version for Qt5 and then you can make a new port for Qt6. In this case let's create a new port instead of a subport as the build system has changed.

@rue-ryuzaki
Copy link
Contributor Author

@reneeotten , as I see, Qt Creator 7.0.0 is based on Qt 6.2.3 and only uses the cmake build system, so Qt Creator 6.0.2 is the latest qt5-qtcreator.

@reneeotten reneeotten marked this pull request as draft November 26, 2024 03:01
@rue-ryuzaki rue-ryuzaki changed the title qt5-qtcreator: update to 14.0.2 qt6-qtcreator: new port Nov 27, 2024
@rue-ryuzaki rue-ryuzaki marked this pull request as ready for review November 29, 2024 17:58
@rue-ryuzaki
Copy link
Contributor Author

@reneeotten Hi, I'm not sure I did everything right.
While I was porting the port file, I discovered that the assembly is carried out by the host compiler. Accordingly, because of this, a build error occurred with clang16 (although clang12 was specified in the Portfile). I tried to fix it for qt5-qtcreator but there were problems with it. Also now there is a problem with building qt5-qtcreator on older macos systems (for example 10.13) due to the qbs update, so there is still a fix in its port. And it will take an indefinite amount of time.

This PR no longer a port update. So, it will be new port, port fix or can be closed (and there will be separate PR)?

I also update the qt creator version from 14.0.2 to 15.0.0 (it was released recently)

@reneeotten
Copy link
Contributor

I will try and take a look at this in the weekend.

@markemer
Copy link
Member

markemer commented Dec 17, 2024

This looks good, I'm ok merging it, but I'd like to get a second opinion from @reneeotten who's kinda the new qt maintainer/expert around here.

Edit: thanks for this, BTW - I haven't been able to get qtcreator working until this port - I think the other version was just to old for my setup.

@markemer markemer merged commit 559a52d into macports:master Dec 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: submission
Development

Successfully merging this pull request may close these issues.

5 participants