Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmt5, gmt6: deprecate gmt5, fix sighandler and cmake #26679

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

remkos
Copy link
Contributor

@remkos remkos commented Nov 19, 2024

Description

This PR thus makes PR #26601 obsolete.
See https://trac.macports.org/ticket/71306

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.1 24B83 x86_64
Command Line Tools 16.1.0.0.1.1729049160

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@remkos
Copy link
Contributor Author

remkos commented Nov 19, 2024

Please note that the gmt6 package passed on all platforms, but not the gmt5 ones.
This is a known issue since #26601 (see also https://trac.macports.org/ticket/71306).

I suggest this PR is accepted so that at least gmt6 works, picking up the sighandler update.
Then some can continue working on gmt5, although we now have marked it obsolete.

science/gmt6/Portfile Outdated Show resolved Hide resolved
science/gmt6/Portfile Outdated Show resolved Hide resolved
science/gmt6/Portfile Outdated Show resolved Hide resolved
science/gmt6/Portfile Outdated Show resolved Hide resolved
@remkos remkos changed the title gmt5, gmt6: deprecate gmt5, fix sighandler patch gmt5, gmt6: deprecate gmt5, fix sighandler and cmake Nov 28, 2024
@reneeotten reneeotten merged commit b901a3c into macports:master Nov 29, 2024
2 of 3 checks passed
@reneeotten
Copy link
Contributor

thanks @remkos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants