mpich{,-doc}: 4.1.2. Use ch3 for now.

[eborisch]

Maintainer update. Use ch3 for hanging finalize with ch4 (pmodels/mpich#6584).

[eborisch]

Also removed '--disable-f08' flag.

[macportsbot]

Notifying maintainers:
@mascguy for port mpi-doc, mpich.

[barracuda156]

@eborisch Default value for Fortran 2008 is enabled, right? If so, this update, as long as it drops manual disabling it, can close this ticket: https://trac.macports.org/ticket/67724

[eborisch]

That is correct, although I have done zero testing of F08, so there may yet be something lurking that needs tweaking.

[barracuda156]

@eborisch While I did not do specific tests, F08 seems to work fine: what was broken without it got fixed with it being enabled.

[eborisch]

@mascguy Any thoughts? Have any chance to test? I've tested MPI functionality for myself without issue.

[barracuda156]

@eborisch Is "F90FLAGS='' F90=''" still needed? I recall it was a hack for something, and perhaps the problem is no longer relevant. But I am not sure here.

[eborisch]

@eborisch Is "F90FLAGS='' F90=''" still needed? I recall it was a hack for something, and perhaps the problem is no longer relevant. But I am not sure here.

I tried a build without these, and the mpifort wrapper was unchanged; I've dropped these old settings with the latest commit.

[barracuda156]

@eborisch As I recall, I have also dropped them on my PowerPC system (away atm), and everything worked normally.

[mascguy]

@mascguy Any thoughts? Have any chance to test? I've tested MPI functionality for myself without issue.

Haven't had time for MacPorts lately, due to my day job. But if you folks are comfortable with this, I'm fine with you merging.

[barracuda156]

@eborisch @catap I am not sure we have this working yet. Building dbcsr 2.6.0 with mpich-clang17 fails for me:

--->  Configuring dbcsr
Executing:  cd "/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_math_dbcsr/dbcsr/work/build" && /opt/local/bin/cmake -G "Ninja" -DCMAKE_BUILD_TYPE=MacPorts -DCMAKE_INSTALL_PREFIX="/opt/local" -DCMAKE_INSTALL_NAME_DIR="/opt/local/lib" -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/usr" -DCMAKE_C_COMPILER="$CC" -DCMAKE_CXX_COMPILER="$CXX" -DCMAKE_OBJC_COMPILER="$CC" -DCMAKE_OBJCXX_COMPILER="$CXX" -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_POLICY_DEFAULT_CMP0060=NEW -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_MAKE_PROGRAM=ninja -DCMAKE_MODULE_PATH="/opt/local/share/cmake/Modules" -DCMAKE_PREFIX_PATH="/opt/local/share/cmake/Modules" -DCMAKE_BUILD_WITH_INSTALL_RPATH:BOOL=ON -DCMAKE_INSTALL_RPATH="/opt/local/lib" -Wno-dev -DPython_EXECUTABLE=/opt/local/bin/python3.11 -DFYPP_EXECUTABLE=/opt/local/bin/fypp-3.11 -DUSE_MPI=ON -DUSE_MPI_F08=ON -DUSE_OPENMP=ON -DUSE_SMM=blas -DWITH_C_API=ON -DWITH_CUDA_PROFILING=OFF -DBUILD_TESTING=ON -DTEST_OMP_THREADS=2 -DTEST_MPI_RANKS=4 -DWITH_EXAMPLES=OFF -DCMAKE_OSX_ARCHITECTURES="arm64" -DCMAKE_OSX_DEPLOYMENT_TARGET="14.0" -DCMAKE_OSX_SYSROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk" -DBLA_VENDOR=OpenBLAS -DBLAS_LIBRARIES=/opt/local/lib/libopenblas.dylib -DLAPACK_LIBRARIES=/opt/local/lib/libopenblas.dylib /opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_math_dbcsr/dbcsr/work/dbcsr-2.6.0 
-- The C compiler identification is Clang 17.0.6
-- The CXX compiler identification is Clang 17.0.6
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /opt/local/bin/mpicc-mpich-clang17
-- Check for working C compiler: /opt/local/bin/mpicc-mpich-clang17 - works
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - failed
-- Check for working CXX compiler: /opt/local/bin/mpicxx-mpich-clang17
-- Check for working CXX compiler: /opt/local/bin/mpicxx-mpich-clang17 - works
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- The Fortran compiler identification is GNU 13.2.0
-- Checking whether Fortran compiler has -isysroot
-- Checking whether Fortran compiler has -isysroot - no
-- Checking whether Fortran compiler supports OSX deployment target flag
-- Checking whether Fortran compiler supports OSX deployment target flag - yes
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - failed
-- Check for working Fortran compiler: /opt/local/bin/mpif90-mpich-clang17
-- Check for working Fortran compiler: /opt/local/bin/mpif90-mpich-clang17 - works
-- Checking whether /opt/local/bin/mpif90-mpich-clang17 supports Fortran 90
-- Checking whether /opt/local/bin/mpif90-mpich-clang17 supports Fortran 90 - no
-- Found OpenMP_C: -fopenmp (found version "5.1") 
-- Found OpenMP_CXX: -fopenmp (found version "5.1") 
-- Found OpenMP_Fortran: -fopenmp (found version "4.5") 
-- Found OpenMP: TRUE (found version "5.1")  
-- Using BLAS for Small Matrix Multiplication
-- Found BLAS: /opt/local/lib/libopenblas.dylib  
-- A library with LAPACK API found.
-- Found MPI_C: /opt/local/bin/mpicc-mpich-clang17 (found version "4.0") 
-- Found MPI_CXX: /opt/local/bin/mpicxx-mpich-clang17 (found version "4.0") 
-- Found MPI_Fortran: /opt/local/bin/mpif90-mpich-clang17 (found version "4.0") 
-- Found MPI: TRUE (found version "4.0") found components: C CXX Fortran 
CMake Error at CMakeLists.txt:219 (message):
  The listed MPI implementation does not provide the required mpi_f08.mod
  interface.


-- Configuring incomplete, errors occurred!

We do need F08 for it: cp2k/dbcsr#661 (comment)
And it worked fine with gcc13 on my PowerPC set-up. But fails now on Sonoma.

svacchanda@Sergeys-MacBook-Air ~ % port -v installed mpich-clang17
The following ports are currently installed:
  mpich-clang17 @4.1.2_0+gcc13 (active) requested_variants='' platform='darwin 23' archs='arm64' date='2023-11-30T19:58:46+0700'

[eborisch]

@eborisch @catap I am not sure we have this working yet. Building dbcsr 2.6.0 with mpich-clang17 fails for me:

Perhaps mpich-gcc13? I don't use the fortran side at all, so someone else will need to track down any issues / fixes.

[barracuda156]

@eborisch @catap I am not sure we have this working yet. Building dbcsr 2.6.0 with mpich-clang17 fails for me:

Perhaps mpich-gcc13? I don't use the fortran side at all, so someone else will need to track down any issues / fixes.

Unfortunately, with Macports obsession with Clang, switching the port to build with gcc may be problematic. Though we need to fix it somehow – currently dbcsr is just broken.