-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sliver toolbar #368
Merged
Merged
feat: Sliver toolbar #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # example/lib/pages/toolbar_page.dart # lib/src/library.dart
# Conflicts: # example/lib/pages/buttons_page.dart
Dart Code Metrics analyze report of macos_ui. ✅Summary
|
On a trip, will have a look soon! |
whiplashoo
approved these changes
Feb 28, 2023
Superb! LGTM |
GroovinChip
added a commit
that referenced
this pull request
Feb 28, 2023
feat: Sliver toolbar (#368) * feat: `SliverToolBar` * chore(example): address lints * docs(SliverToolbar): update `floating` doc * feat(example): add page for SliverToolbar * chore: dart format * docs(SliverToolBar): slight change to `pinned` docs * docs(SliverToolBar): add section to readme * docs(SliverToolBar): tweak sample * test(SliverAppBar): add initial tests * chore: update version & changelog * chore: pub upgrade * chore: remove unused imports * test: remove ignore lint
GroovinChip
added a commit
that referenced
this pull request
Feb 28, 2023
* feat: Sliver toolbar (#368) * feat: `SliverToolBar` * chore(example): address lints * docs(SliverToolbar): update `floating` doc * feat(example): add page for SliverToolbar * chore: dart format * docs(SliverToolBar): slight change to `pinned` docs * docs(SliverToolBar): add section to readme * docs(SliverToolBar): tweak sample * test(SliverAppBar): add initial tests * chore: update version & changelog * chore: pub upgrade * chore: remove unused imports * test: remove ignore lint * fix(SidebarItem): use theme's primary color instead of hardcoded value (#374) * fix(SidebarItem): use theme's primary color instead of hardcoded value Fixes #313 * chore: update version, changelog
Merged
GroovinChip
added a commit
that referenced
this pull request
Apr 6, 2023
* feat: `SliverToolBar` * chore(example): address lints * docs(SliverToolbar): update `floating` doc * feat(example): add page for SliverToolbar * chore: dart format * docs(SliverToolBar): slight change to `pinned` docs * docs(SliverToolBar): add section to readme * docs(SliverToolBar): tweak sample * test(SliverAppBar): add initial tests * chore: update version & changelog * chore: pub upgrade * chore: remove unused imports * test: remove ignore lint # Conflicts: # example/lib/pages/fields_page.dart # example/lib/pages/toolbar_page.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
SliverToolbar
widget, which allows developers to achieve effects like those desired in #321.Closes #321
Pre-launch Checklist
CHANGELOG.md
with my changes