Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported version MySQL 5.7 or more #4

Merged
merged 6 commits into from
Dec 29, 2022
Merged

Supported version MySQL 5.7 or more #4

merged 6 commits into from
Dec 29, 2022

Conversation

yseto
Copy link
Contributor

@yseto yseto commented Dec 29, 2022

No description provided.

@yseto yseto self-assigned this Dec 29, 2022
Arthur1
Arthur1 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@Arthur1 Arthur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

README.md Outdated
@@ -16,3 +16,6 @@ mackerel-plugin-mysql [-host=<host>] [-port=<port>] [-username=<username>] [-pas
command = "/path/to/mackerel-plugin-mysql"
```

## Supported MySQL version

mysql 5.7, 8.0 above
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] 8.0 and above

@yseto yseto merged commit 22155b0 into main Dec 29, 2022
@yseto yseto deleted the supported-version-mysql57-or-more branch December 29, 2022 09:13
@yseto
Copy link
Contributor Author

yseto commented Dec 29, 2022

Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arthur1 Arthur1 Arthur1 approved these changes

Assignees

@yseto yseto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yseto @Arthur1