Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-constant format string in call in tests #162

Merged

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Oct 26, 2024

Go 1.24 will add verification of non-constant format strings.
It runs vet on testing so it fails on the mackerel-client-go tests.
See golang/go#60529.

 $ gotip test ./...                      
# github.com/mackerelio/mackerel-client-go
# [github.com/mackerelio/mackerel-client-go]
./mackerel_test.go:129:12: non-constant format string in call to (*github.com/mackerelio/mackerel-client-go.Client).tracef
./mackerel_test.go:147:12: non-constant format string in call to (*github.com/mackerelio/mackerel-client-go.Client).tracef
./mackerel_test.go:165:12: non-constant format string in call to (*github.com/mackerelio/mackerel-client-go.Client).tracef
./mackerel_test.go:182:12: non-constant format string in call to (*github.com/mackerelio/mackerel-client-go.Client).tracef
FAIL    github.com/mackerelio/mackerel-client-go [build failed]
FAIL

Copy link
Contributor

@yohfee yohfee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting!

@yohfee yohfee merged commit 04b1b9d into mackerelio:master Oct 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants