Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid to store invalid numbers in the plugin state #29

Merged
merged 2 commits into from
Jun 28, 2021
Merged

avoid to store invalid numbers in the plugin state #29

merged 2 commits into from
Jun 28, 2021

Conversation

lufia
Copy link
Member

@lufia lufia commented Jun 28, 2021

I fixed two plugins, but we perhaps have some plugins that try to save invalid numbers to the plugin state.

see mackerelio/mackerel-agent-plugins#770 and mackerelio/mackerel-agent-plugins#779

@coveralls
Copy link

coveralls commented Jun 28, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 977826585

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.02%) to 85.135%
Totals Coverage Status
Change from base Build 663534955: 1.02%
Covered Lines: 189
Relevant Lines: 222
💛 - Coveralls

astj
astj approved these changes Jun 28, 2021
View reviewed changes
mackerel-plugin.go Outdated Show resolved Hide resolved
@lufia lufia merged commit eb4c26c into master Jun 28, 2021
@lufia lufia deleted the invalid-nums branch June 28, 2021 05:20
@lufia lufia mentioned this pull request Jun 28, 2021
Merged
@astj astj mentioned this pull request Jul 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astj astj astj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lufia @coveralls @astj