Fix #167 #168
Merged
Fix #167 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid modifying the buffer used to generate string slices
…-safety Fix/json stringify panic json parse safety
| @@ -66,20 +66,20 @@ pub trait Generator { | |||
|
|
|||
| #[inline(never)] | |||
| fn write_string_complex(&mut self, string: &str, mut start: usize) -> io::Result<()> { | |||
| self.write(string[ .. start].as_bytes())?; | |||
| self.write(&string.as_bytes()[ .. start])?; | |||
There was a problem hiding this comment.
the changes in this function prevent panics when indexing into a string at a byte offset that doesn't fall on a character boundary
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167 and prevents panics found in the
stringifyfunction when fuzzing with AFL.Also adds a number of tests to reproduce the fuzzing results and to test the changes to the parsing logic.