Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make soundtrack state configurable, closes #5 #6

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Make soundtrack state configurable, closes #5 #6

merged 2 commits into from
Oct 19, 2019

Conversation

dmrib
Copy link
Member

@dmrib dmrib commented Oct 19, 2019

This PR solves the Chrome issues when looping the sketch soundtrack and includes a method for controlling its state.

Pure magic 🎉

@anothergoldenmonkey anothergoldenmonkey changed the base branch from master to gh-pages October 19, 2019 07:40
@anothergoldenmonkey anothergoldenmonkey changed the base branch from gh-pages to master October 19, 2019 07:40
anothergoldenmonkey
anothergoldenmonkey reviewed Oct 19, 2019
View reviewed changes
Copy link
Member

@anothergoldenmonkey anothergoldenmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some small comments. Not super important, but I'll wait your feedback on those. In general, pretty nice. I like the keyboard, by the way. 🎹

src/sketch.js Outdated Show resolved Hide resolved
src/sketch.js Outdated Show resolved Hide resolved
anothergoldenmonkey
anothergoldenmonkey approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@anothergoldenmonkey anothergoldenmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@anothergoldenmonkey anothergoldenmonkey merged commit b75d9d4 into machinegrooving:master Oct 19, 2019
@dmrib dmrib deleted the dmrib/sound branch October 19, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anothergoldenmonkey anothergoldenmonkey anothergoldenmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmrib @anothergoldenmonkey