Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed sql types access to pub #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IDEA-godwin
Copy link

the trait SqlTypes is not pub.

I needed to define a method parameter to values that have the SqlType trait but noticed that the sdk does not exposes the trait, making it impossible to do as I can not use ws_sdk::database::sql_types::SqlType

@Liuhaai
Copy link
Collaborator

Liuhaai commented Jul 6, 2023

Hi IDEA-godwin, thx for the pr. Our host only supports serveral params currently. So SqlType isn't exposed at the first. Actually, you can add an implementation as a pr directly if it's common https://github.com/machinefi/w3bstream-wasm-rust-sdk/blob/main/src/database/sql_types.rs#L82
it would be great if you could share your implementation for SqlType trait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants