Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform Quit menu item display is awkward #374

Closed
machawk1 opened this issue Mar 1, 2019 · 2 comments
Closed

Cross-platform Quit menu item display is awkward #374

machawk1 opened this issue Mar 1, 2019 · 2 comments

Comments

@machawk1
Copy link
Owner

machawk1 commented Mar 1, 2019

In Windows, the Exit menu is often the last entry in the File menu, which is displayed as the most-left menu.

The current implementation in Windows, to align with macOS, displays QUIT (note, all-caps) in the Help menu, which is the last menu in the horizontal series and QUIT is the last entry in this menu.

wxPython does something strange in macOS (by design) that requires this entry to be in the "help menu" to display in the WAIL menu on macOS. TODO: Match the paradigms to the platforms.

About is often the last entry on Windows and has the "A" menu shortcut/accelerator, which is not currently present in WAIL for Windows (from src)

@machawk1 machawk1 changed the title Cross-platform Quit functionality is awkward Cross-platform Quit menu item display is awkward Mar 1, 2019
machawk1 added a commit that referenced this issue Mar 1, 2019
@machawk1
Copy link
Owner Author

machawk1 commented Mar 1, 2019

In 58a751c :

  • Move Quit from Help to File menu
  • Rename Quit to Exit
  • Move About... to bottom of Help menu
  • Add shortcut for About entry (and others)

@machawk1
Copy link
Owner Author

machawk1 commented Mar 1, 2019

Per the Issue title, the menus are now less awkward across platforms, so closing it with shortcuts to be addressed later.

@machawk1 machawk1 closed this as completed Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant