Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of mementos does not have place-value delimiter #308

Closed
machawk1 opened this issue Feb 9, 2018 · 3 comments
Closed

Number of mementos does not have place-value delimiter #308

machawk1 opened this issue Feb 9, 2018 · 3 comments

Comments

@machawk1
Copy link
Owner

machawk1 commented Feb 9, 2018

See http://machawk1.github.io/wail/images/wail_0.2018.02.09_basic.png,
"5117" should be "5,117" or whatever delimiter is appropriate for the locale (which we currently don't handle, so make it "," initially).

@machawk1
Copy link
Owner Author

machawk1 commented Feb 10, 2019

Re-opening, no longer seems to be working as of 2f264ad

screen shot 2019-02-09 at 7 25 39 pm

This only appears to be an issue in the .app, not when run from the .py scripts. I wonder if some of the locale settings don't carry over to the binary.

@machawk1 machawk1 reopened this Feb 10, 2019
@machawk1
Copy link
Owner Author

locale.setlocale(locale.LC_ALL, '') -> locale.setlocale(locale.LC_ALL, 'en_US') will fix this but decouples from the system locale, so will be incorrect (e.g.) in instances where "," and "." are delimiters for decimal and thousands separator, respectively.

@machawk1
Copy link
Owner Author

The above breaks the build on Windows, as the en_US locale is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant