Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.5: Fix ADDFILE segfault #34

Merged
merged 3 commits into from
Dec 17, 2020
Merged

1.4.5: Fix ADDFILE segfault #34

merged 3 commits into from
Dec 17, 2020

Conversation

mach-kernel
Copy link
Owner

@mach-kernel mach-kernel commented Dec 16, 2020

Should resolve #24 and #33. Surprised this wasn't more of a problem...

Now also includes changes from #32!

@wyatt-wong
Copy link

@peterferrie According to the page https://github.com/sicklittlemonkey/cadius, the building of Cadius actually refer to the git clone https://github.com/mach-kernel/cadius.git branch instead of https://github.com/sicklittlemonkey/cadius

@mach-kernel
Copy link
Owner Author

That's a forked copy of this repository from someone who has contributed some patches (so the README still links here). It unfortunately has the same bug.

@wyatt-wong
Copy link

That's a forked copy of this repository from someone who has contributed some patches (so the README still links here). It unfortunately has the same bug.

I was unable to compile the Cadius downloaded from https://github.com/sicklittlemonkey/cadius and got errors. Building Cadius from https://github.com/mach-kernel/cadius/ works fine. I am not sure what's wrong with the cadius repository of sicklittlemonkey.

@mach-kernel mach-kernel merged commit f38d3d5 into master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes on Ubuntu 18.04 LTS x64
2 participants