Expose CPU related metrics from page.metrics() as phantomas metrics #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds 6 new metrics, taken from Puppeteer's page.metrics() values:
The
scriptDuration
looks particularly important to me, as pages tend to have more and more JS on the web. More information here: https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#pagemetricsDon't hesitate if you'd like me to change things such as metrics names, or if I forgot something.
(I can't add tests, as time-based values fluctuate too much. Count values are more stable, but they might also change with browser updates.)