fix simple-queue by enforcing only one done() call per push #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanial
force-pushed
the
fix-simple-queue
branch
from
529fe62 to
b9044cc
Compare
macbre
approved these changes
Nov 3, 2016
| 'should call both callbacks, even though the first callback calls done() multiple times': function(err, callbackOneIsCalled, callbackTwoIsCalled) { | ||
| assert.equal(callbackOneIsCalled, true); | ||
| assert.equal(callbackTwoIsCalled, true); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where calling the
done()function multiple times within a singlepush()will keep advancing the queue, and cause it to skip over the otherpush()functions.I encountered this bug while trying to use the
post-load-delayfunction. Another part of the code was callingdone()multiple times, so phantomas wasn't waiting for the postLoadDelay'sdone()function to be invoked before exiting.