Update SlimerJS min version #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
graingert/slimerjs#34 reports the same issue Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
My project contains phantomas as a npm dependency. For an unknown reason, when running
npm installon Travis, npm tries to install theslimerjspackage in version0.9.5, although version0.9.6exists.And it fails! It looks like they recently changed the binaries download urls, that could explain the failure.
Take a look at this Travis build for example: https://travis-ci.org/gmetais/YellowLabTools/builds/101186325
Locally, or on my server, I have no problem, npm directly downloads
0.9.6. The only bug is with my Travis. Your own Travis tests download the right version.This merge request simply updates the minimal version of SlimerJS and it fixes my Travis problem.