Adding support for persistant cookies via cookie jar argument. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,6 +63,8 @@ var phantomas = function(params) { | |||
| // parse script CLI parameters | |||
| this.params = params; | |||
|
|
|||
| this.cookieJar = params['cookie-jar'] || false; | |||
|
|
|||
|
@cphoover, nice one! Looks fine. I've left some minor inline comments. |
ghost
assigned 
|
Ok will fix up and send it back to you, when I get back from work. |
|
@cphoover, thanks for the fixes. I'll take a look at this later today and merge it. |
|
cool |
macbre
added a commit
that referenced
this pull request
Dec 3, 2013
Adding support for persistant cookies via cookie jar argument.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for persistent cookies across requests by adding a
argument switch to the command.
Implemented with fs phantom module, cookies are serialized as JSON.