Use the new head{-less,-full} mode for Chrome #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the new That behaviour makes it behave more like a browser, but causes tests to fail massively: |
The default 404 response is served as an HTML which skews our asserted metrics. $ curl 0.0.0.0:8888/favicon.ico -I HTTP/1.1 204 No Content Date: Fri, 09 Jun 2023 18:41:05 GMT Connection: keep-alive Server: nginx
macbre
commented
Jun 9, 2023
Comment on lines
+22
to
+25
| # no content for the favicon (the default 404 response is treated as HTML) | ||
| location /favicon.ico { | ||
| return 204; | ||
| } |
There was a problem hiding this comment.
This will skip including the /favicon.ico response in the gzipRequests and htmlCount metrics.
macbre
commented
Jun 12, 2023
| offenders: | ||
| requests: | ||
| - { url: "http://127.0.0.1:8888/browser-caching.html", type: "html", size: 517 } | ||
| - { url: "http://127.0.0.1:8888/static/jquery-2.1.1.min.js", type: "js", size: 29734 } | ||
| - { url: "http://127.0.0.1:8888/favicon.ico", type: "other", size: 103 } |
There was a problem hiding this comment.
Here's the cause of all these increased requests expected values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1279
See https://developer.chrome.com/articles/new-headless/