Use mkcert to set up trusted development certificates

.github/workflows/dockerimage.yml

@@ -34,11 +34,11 @@ jobs:
         docker images
         docker inspect --format='{{json .Config.Labels}}' ${{ env.DOCKER_TAG }} | jq
 
-    - name: Run tests inside the Docker container
+    - name: Run phantomas CLI script inside the container
       run: |
         ./test/server-start.sh
 
         docker run \
           --network=host \
           --security-opt seccomp=$(pwd)/chrome-seccomp.json \
-          ${{ env.DOCKER_TAG }} npm t
+          ${{ env.DOCKER_TAG }} ./bin/phantomas.js http://127.0.0.1:8888/ --pretty

.github/workflows/tests.yml

@@ -29,6 +29,25 @@ jobs:
     - name: Install dependencies
       run: npm ci
 
+    - name: Install mkcert and generate trusted development certificates
+      run: |
+        sudo apt update -y && sudo apt install -y libnss3-tools
+        curl -JLO "https://dl.filippo.io/mkcert/latest?for=linux/amd64"
+        chmod +x mkcert-v*-linux-amd64
+        sudo cp mkcert-v*-linux-amd64 /usr/local/bin/mkcert
+
+        mkcert -version
+
+        # https://github.com/FiloSottile/mkcert/issues/219
+        mkdir -p $HOME/.pki/nssdb
+        certutil -d sql:$HOME/.pki/nssdb -N --empty-password
+        mkcert -install
+
+        ./test/ssl-certificate/generate.sh
+
+    - name: Start the test server
+      run: ./test/server-start.sh
+
     - name: Run example script
       env:
         DEBUG: "phantomas:browser"
@@ -37,9 +56,6 @@ jobs:
     - name: Run tests
       run: |
         set -o pipefail
-
-        ./test/server-start.sh
-
         npm test 2>&1 | tee /tmp/npm-test.log
 
     - name: Code coverage to be improved

package.json

@@ -58,8 +58,8 @@
       "global": {
         "statements": 89,
         "branches": 85,
-        "functions": 90,
-        "lines": 90
+        "functions": 89,
+        "lines": 89
       }
     }
   }

test/README.md

@@ -1,6 +1,16 @@
 phantomas tests
 ===============
 
+## Initial set up
+
+We use [`mkcert`](https://github.com/FiloSottile/mkcert) for setting up trusted development certificates to be used when testing locally.
+
+1. Follow [the instruction steps](https://github.com/FiloSottile/mkcert#installation).
+2. Run `mkcert -install`
+3. Run `./test/ssl-certificate/generate.sh`
+
+## Run the tests
+
 Start the testing server:
 
 ```
@@ -12,11 +22,3 @@ And then run the test suite:
 ```
 phantomas$ npm test
 ```
-
-### Travis CI
-
-```
-$ which google-chrome-stable && google-chrome-stable --version
-/usr/bin/google-chrome-stable
-Google Chrome 71.0.3578.98 
-```

test/integration-spec.yaml

@@ -829,8 +829,6 @@
 # http/1.1 (legacy one)
 - url: "https://127.0.0.1:8889"
   label: "localhost with http/1.1 and TLS 1.2"
-  options:
-    ignore-ssl-errors: true
   metrics:
     mainDomainHttpProtocol: "http/1.1"
     oldHttpProtocol: 1
@@ -853,8 +851,6 @@
 # http/2
 - url: "https://127.0.0.1:9000"
   label: "localhost h2 version"
-  options:
-    ignore-ssl-errors: true
   metrics:
     mainDomainHttpProtocol: "h2"
     oldHttpProtocol: 0
@@ -866,8 +862,6 @@
 - url: "https://gf.dev/http3-test"
   label: "h3"
   flaky: Reaches the timeout of 5000 ms
-  options:
-    ignore-ssl-errors: true
   metrics:
     mainDomainHttpProtocol: "h3"
     mainDomainTlsProtocol: "QUIC"

test/ssl-certificate/generate.sh

@@ -1,4 +1,7 @@
 #!/bin/sh
 # https://github.com/FiloSottile/mkcert#installation
-mkcert -cert-file localhost.crt -key-file localhost.key localhost 127.0.0.1 0.0.0.0 ::1
+SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"
 
+echo "Using $SCRIPTPATH directory ..."
+
+mkcert -cert-file ${SCRIPTPATH}/localhost.crt -key-file ${SCRIPTPATH}/localhost.key localhost 127.0.0.1 0.0.0.0 ::1

test/ssl-certificatelocalhost.key

@@ -0,0 +1,28 @@
+-----BEGIN PRIVATE KEY-----
+MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQCkMrSe8FBeoPky
+Qs/367iYrzThU8lg0HTh2I9amUY4FQSxOf71J2R52D6sgy7xlugBLcZT+xnrTSFt
+3dH508Tvi62sNrMWqNcCOlchzleI+yF/reW7fiDaG1+NcklQUC6U2FsVCYgcpFCy
+RM8owylk4YyCTP1LxjKmCNk/o52SBJyo5yfM2Y/SYyfokuL0bpXh39//27pvA6fV
+hWaRlAqnVxapE+debSieySSjjsn95pr0Oh2vT9Qb57h+BaLTPYlr0yq34iKBhEPs
++rbyegaZU/wJV/K2S8tHkRXt2xnLdv/zbfPZp5k/b+ULHpOt3S/+W8kwsTNxLop7
+x9SVviKPAgMBAAECggEATR/gBRO9vGUCB+CoDLx0zYrmXLxdR5NCg16UHysFd4wv
+0wr5va8OG8k9zwwjPajzOrKEiKfWSdbFz/Q0D5Ov2hCSt+RNhGQz8cDzclaYeSf0
+WSOWV9XrmmbnH+pBk27GInXpel0qyMFJgiKd53ib9d2XgRCmnTPwUFqxqJmyhoXR
+NeE3tDYqKsaso/PSb3x5l7sGcHQBTX/Oeu6rlCBT6LtHnKiO0/cPSUY6Uh1SIfsd
+xG1pL7/nddC2R5nOWHF6w2xOA7h86B8CbNTeJghBpr5+vNiQ4UkaF5V++hUzHksM
+uU8zdIPf/JQ2EHIH3pOVMrmIAYUQHc02Ud0KtZOJoQKBgQDXV0FOa0vtEt2+A0fb
+z6DklFrUS+xBYS+U3nYTqW1j6zlq82wgg92q9id4kNIqKbFQzVCDGyVG/InBEYL9
+ElZ5OdkILrpwBuiWVi4qLIAH1hDKbDVaXpYZGw8P0ejnU4XWb/Jcmi4VMwYnJQZ9
+E+cLjrlCkJWcPO0VtkjpLWGEXwKBgQDDM2gDRD9vQzXyufyCvNvrzDzvEOH+hIz6
+d62clRr7t+gC4Z9D4nhguT5BIZ4cHxxeLE7sm/UzWcM1RPlavzdBYwajkihMjtE/
+O73dDz1VrzozLKeqiBPO5IAsSM14hVAvDr1O2UoxKAee+TIfukZYrScSre/qpHkK
+h8cVXdCP0QKBgQDMCn904LIWtvOpIc6q9veK3w+ZbT81S/Mb6haT1swyCyZisrhX
+rtsRLSCFWyPok4zR9Vk+gTA3LP8SE5e8V+3b+/YrjKtXjxQ/rvUbPQMraaiLRTDg
+qhMrQrpo0QsQddGxOG27VNQpfilsWebmCT+5cckUy48XdZtoIUrAtyFZnQKBgG+e
+XpS3mtphgWDJjyWnHs5n3FQLwF7Mpty2QJUwAdz8XXQAVhT4VENiycFumr2T4KHN
+DlhoGb8CTgiQ51FH1C3UlUBFXDvi0q4o2Dmm9Dih2VLX7wwpgcIlkVFBVBTdjmtK
+L1/+ClmvfSQfdNUFrCIa6SPaSD1RTVGDMIj8Oz1xAoGAJyaarythvBUTaHeTbQYB
+qJqAcHAtn8LINSHQwFGKeIO83oyi4jmj5sx13t5RlCrt0uakZ7+YPLKBfbpbIN4H
+TvFoNi6C5QwZYhxShxffI/tyU9/dzY5oTr9JoiB+w6xy3QEzQxv7fTlkFg1QeKZv
+eS3qUJb43K6p8kbq0IlLJ7c=
+-----END PRIVATE KEY-----