Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to the latest puppeteer (13.7.0) - HeadlessChrome/101 #1142

Merged
merged 9 commits into from
May 4, 2022

Conversation

macbre
Copy link
Owner

@macbre macbre commented May 3, 2022

+        "puppeteer": "^13.7.0"
2022-05-03T22:23:28.094Z phantomas:browser Original browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/101.0.4950.0 Safari/537.36

TODO

  • fix tests for oldTlsProtocol metric - node ./examples/index.js https://127.0.0.1:8889 reportsError: net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH at https://127.0.0.1:8889 // 647a467

@macbre
Copy link
Owner Author

macbre commented May 3, 2022

  ● Integration tests › h3 › should have "mainDomainTlsProtocol" metric set properly

    assert.strictEqual(received, expected)

    Expected value to strictly be equal to:
      "QUIC"
    Received:
      0

and

2022-05-03T22:46:00.1905226Z   ● Integration tests › localhost but https version › should have "oldTlsProtocol" metric set properly
2022-05-03T22:46:00.1905472Z 
2022-05-03T22:46:00.1905689Z     net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH at https://127.0.0.1:8889

macbre added 2 commits May 3, 2022 23:44
This should fix an "net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH" issue.
@macbre macbre changed the title Bump to the latest puppeteer Bump to the latest puppeteer (13.7.0) May 3, 2022
@macbre macbre changed the title Bump to the latest puppeteer (13.7.0) Bump to the latest puppeteer (13.7.0) - HeadlessChrome/101 May 3, 2022
    net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH at https://127.0.0.1:8889
@macbre
Copy link
Owner Author

macbre commented May 3, 2022

Test Suites: 1 failed, 13 passed, 14 total
Tests:       6 failed, 1 skipped, 502 passed, 509 total

@macbre
Copy link
Owner Author

macbre commented May 4, 2022

We're still randomly failing with:

  ● Integration tests › /not-found.html › should get results from a promise

    Navigation failed because browser has disconnected!

      at node_modules/puppeteer/src/common/LifecycleWatcher.ts:112:13
      at node_modules/puppeteer/vendor/mitt/src/index.ts:88:75
          at Array.map (<anonymous>)
      at Object.emit (node_modules/puppeteer/vendor/mitt/src/index.ts:88:56)
      at CDPSession.emit (node_modules/puppeteer/src/common/EventEmitter.ts:102:18)

@macbre macbre enabled auto-merge (squash) May 4, 2022 22:06
@macbre macbre merged commit 643ffd2 into devel May 4, 2022
@macbre macbre deleted the puppeteer-latest branch May 4, 2022 22:06
@macbre macbre mentioned this pull request May 5, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant