-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --runs option to phantomas #172
Comments
When this is integrated, it would be awesome if the multi-run can support all of the arguments that a single run accepts. I have been making custom modifications to the if (params.viewport !== 'undefined') {
cmd.push(' --viewport=' + params.viewport);
}
if (params['user-agent'] !== 'undefined') {
cmd.push(' --user-agent=\'' + params['user-agent'] + '\'');
} |
@macbre any chance to get that in v1.0? I need to do major changes on my side with v1.0 already. Would be nice to not have more major changes at grunt-phantomas in v1.1. If not, no problem. ;) |
@stefanjudis, I keep adding more and more features to v1.0 :) Merging |
Perfect!!! Thank you. 😄 |
Actually, here comes the question: how to provide the results of each run? Currently npm module is provided with a JSON with single run results. How should multiple results be provided / aggregated? |
Hmm.
That's a breaking change for the current implementation and its dependants, but well it's a major release. It's allowed. ;) |
No problem. :) |
* Build(deps): bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#171) Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.2.0...v2.2.1) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): bump puppeteer from 20.8.1 to 20.8.3 (#172) Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 20.8.1 to 20.8.3. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-v20.8.1...puppeteer-v20.8.3) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): bump puppeteer from 20.8.3 to 20.9.0 (#173) Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 20.8.3 to 20.9.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-v20.8.3...puppeteer-v20.9.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add AVIF as an image type (#1299) Co-authored-by: Maciej Brencz <[email protected]> * Fix a false JSError reported by Phantomas (#1296) Co-authored-by: Maciej Brencz <[email protected]> * v2.9.0 * (deps) bump puppeteer to v21.0.2 * Update from upstream Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update from upstream * Introduce a new analyze-images module with a few rules * Linter / prettifier / make-docs * Update package.json + package-lock.json * Fix package-lock.json --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maciej Brencz <[email protected]> Co-authored-by: macbre <[email protected]>
run-multiple.js
with main phantomas "binary"--runs
optionWaiting for #152
The text was updated successfully, but these errors were encountered: