Merge pull request #621 from gmetais/fix-cookies

Quick fix for cookie regression in PhantomJS 2.1
macbre · Mar 26, 2016 · 4980320 · 4980320
2 parents 57ed4f3 + 22f46ae
commit 4980320
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/extensions/cookies/cookies.js b/extensions/cookies/cookies.js
@@ -4,7 +4,7 @@
 /* global phantom: true */
 'use strict';
 
-exports.version = '1.0';
+exports.version = '1.1';
 
 exports.module = function(phantomas) {
 
@@ -74,7 +74,8 @@ exports.module = function(phantomas) {
 				}
 
 				if (!phantom.addCookie(cookie)) {
-					throw 'PhantomJS could not add cookie: ' + JSON.stringify(cookie);
+					// In PhantomJS 2.1, the addCookie function always returns false (#597).
+					//throw 'PhantomJS could not add cookie: ' + JSON.stringify(cookie);
 				}
 
 				phantomas.log('Cookies: set ' + JSON.stringify(cookie));

diff --git a/test/integration-spec.yaml b/test/integration-spec.yaml
@@ -9,6 +9,8 @@
 
 # DOM operations
 - url: "/dom-operations.html"
+  options:
+    cookie: "bar=foo;domain=url"
   metrics:
     requests: 3
     cssCount: 1