fix: Address PyTorch Model Loading Deprecation Warning (GH-30) #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the PyTorch deprecation warning related to loading models without explicitly setting the
only_weights
parameter (#30). This warning stems from a security concern with using thepickle
library for loading model objects, as it can potentially execute arbitrary code.While this is unlikely to be an issue with the model shipped with this package, it could pose a risk when loading custom models or if unexpected behavior arises in future versions.
To mitigate this:
only_weights=True
as the default when loading the model. This loads only the model weights and avoids potential security risks associated with unpickling.only_weights=True
does not affect its behavior. This test compares the loaded parameters and predictions between the two loading methods across various audio inputs.Our tests confirm that using
only_weights=True
does not alter the model's functionality, allowing us to safely address the deprecation warning and enhance security.Thanks to @revilodarnoc for filing the issue!