Completed the assignment! #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art 0. All the test passed
…class_structure,test_static_types, test_type_relationship have passed
Worked on checking if the method name exist, and if the parameters are right
Worked on implementing the type error messages for the 1.3.
fixed the check_types() for ConstructorCall()! There are five types that are not passing regarding the types of arguemnts passed in. Tried solving but I cant seem to find where I got it wrong!
In check_types() of method, instead of raising the JavaTypeError, I was just rasing the TypeError. Fixed it, and a few more tests are passing
Fixed the same typo in rasing JavaTypeError in Constructor Call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for my late pull request! I didn't know that I was supposed to make a pull request.