Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chebyshev documentation #230

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Chebyshev documentation #230

wants to merge 15 commits into from

Conversation

mrhardman
Copy link
Collaborator

Addition of documentation of fundamental Chebyshev grid operations.

Please review the notes and give comments! @LucasMontoya4 @johnomotani @mabarnes

@LucasMontoya4
Copy link
Collaborator

I'm not sure if I'm just going to the wrong page over and over, but it looks to me like the latest commit is an empty file docs/src/chebyshev.md, so I can't edit the previous commit documentation (which actually has the content)...? Just on the typo side of things. I'll look more closely at the maths now lol

@mrhardman
Copy link
Collaborator Author

mrhardman commented Jul 29, 2024 via email

@johnomotani
Copy link
Collaborator

johnomotani commented Jul 30, 2024

Still seem to be some bugs in the formatting. If you go into the docs/ subdirectory and, in that directory, do (if I'm remembering right...)

$ julia --project
julia> ]
pkg> dev ../moment_kinetics
pkg> dev ../makie_post_processing
pkg> dev ../plots_post_processing
pkg> <backspace>
julia> include("make.jl")

Then it should build the documentation in docs/build/. You can open docs/build/index.html with a web browser to check the page. If you leave the Julia REPL open, running include("make.jl") will be slow the first time, but fast the second time and afterwards.

@johnomotani
Copy link
Collaborator

@LucasMontoya4 if you look at the 'Files changed' tab on the PR page, you can see all the changes, and add comments/suggestions.

@johnomotani
Copy link
Collaborator

@mrhardman the link to the preview docs is the one beside the documenter/deploy CI job, which you can follow through to here for the Chebyshev page https://mabarnes.github.io/moment_kinetics/previews/PR230/chebyshev/.

@mrhardman
Copy link
Collaborator Author

@mrhardman the link to the preview docs is the one beside the documenter/deploy CI job, which you can follow through to here for the Chebyshev page https://mabarnes.github.io/moment_kinetics/previews/PR230/chebyshev/.

I seem to have misunderstood the required syntax. This version renders properly https://github.com/mabarnes/moment_kinetics/blob/chebyshev_documentation/docs/src/chebyshev.md Can you tell me where I can find the instructions on syntax? Happy for this to be fixed by search and replace if this is trivial for you.

@mrhardman
Copy link
Collaborator Author

Chebyshev docs should now render correctly @LucasMontoya4 if you want to try and continue your review of these notes at the link suggested by John above https://mabarnes.github.io/moment_kinetics/previews/PR230/chebyshev/. Happy to modify the docs with suggestions before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants