Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial docker #20

Merged
merged 12 commits into from
Jan 31, 2020
Merged

Initial docker #20

merged 12 commits into from
Jan 31, 2020

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Jan 31, 2020

Work-in-progress

@brylie
Copy link
Contributor Author

brylie commented Jan 31, 2020

Currently getting an error when running docker-compose up

python: error while loading shared libraries: libpython3.7m.so.1.0: cannot open shared object file: No such file or directory
ERROR: Service 'api' failed to build: The command '/bin/sh -c python -m pip install pipenv' returned a non-zero code: 127

@brylie brylie mentioned this pull request Jan 31, 2020
Closed
@brylie
Copy link
Contributor Author

brylie commented Jan 31, 2020

@MarkusShepherd reports that the Dockerfile (and docker-compose) works for him.

I am thinking this might have to do with my local Docker installation, as there isn't yet official Docker packaging for Ubuntu 19.10:

docker/for-linux#832

MarkusShepherd
MarkusShepherd suggested changes Jan 31, 2020
View reviewed changes
Copy link

@MarkusShepherd MarkusShepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few comments on the Dockerfile.

api/Dockerfile Show resolved Hide resolved
api/Dockerfile Outdated Show resolved Hide resolved
api/Dockerfile Outdated Show resolved Hide resolved
api/Dockerfile Outdated Show resolved Hide resolved
api/docker-compose.debug.yml Outdated Show resolved Hide resolved
@huksley
Copy link
Contributor

huksley commented Jan 31, 2020

@MarkusShepherd reports that the Dockerfile (and docker-compose) works for him.

Yes, it works for me too.

@brylie brylie requested a review from MarkusShepherd January 31, 2020 08:52
@brylie
Copy link
Contributor Author

brylie commented Jan 31, 2020

@MarkusShepherd I made the requested changes.

huksley
huksley reviewed Jan 31, 2020
View reviewed changes
Copy link
Contributor

@huksley huksley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to fix servers entry which is generated as empty now?

image

api/Dockerfile Show resolved Hide resolved
api/Dockerfile Outdated Show resolved Hide resolved
MarkusShepherd
MarkusShepherd previously approved these changes Jan 31, 2020
View reviewed changes
Copy link

@MarkusShepherd MarkusShepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brylie
Copy link
Contributor Author

brylie commented Jan 31, 2020 •
edited
Loading

Any way to fix servers entry which is generated as empty now?

I'm not sure how to set the default servers, nor what value to use. What do you recommend @huksley?

@brylie brylie mentioned this pull request Jan 31, 2020
Open
MarkusShepherd
MarkusShepherd approved these changes Jan 31, 2020
View reviewed changes
Copy link

@MarkusShepherd MarkusShepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brylie brylie merged commit f707a6a into master Jan 31, 2020
@brylie brylie deleted the initial-docker branch January 31, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huksley huksley huksley left review comments

@MarkusShepherd MarkusShepherd MarkusShepherd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brylie @huksley @MarkusShepherd