Fixes #305, exception thrown when using "visibility" as a custom attr…

…ibute with MvcSiteMapNodeAttribute.
maartenba · Apr 8, 2014 · 92ad5eb · 92ad5eb
1 parent 4e5c013
commit 92ad5eb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/MvcSiteMapProvider/MvcSiteMapProvider/Collections/Specialized/AttributeDictionary.cs b/src/MvcSiteMapProvider/MvcSiteMapProvider/Collections/Specialized/AttributeDictionary.cs
@@ -151,7 +151,7 @@ public void AddRange(string jsonString)
         public void AddRange(string jsonString, bool throwIfReservedKey)
         {
             var items = this.jsonToDictionaryDeserializer.Deserialize(jsonString);
-            this.AddRange(items);
+            this.AddRange(items, throwIfReservedKey);
         }
 
         /// <summary>

diff --git a/src/MvcSiteMapProvider/MvcSiteMapProvider/Collections/Specialized/RouteValueDictionary.cs b/src/MvcSiteMapProvider/MvcSiteMapProvider/Collections/Specialized/RouteValueDictionary.cs
@@ -146,7 +146,7 @@ public void AddRange(string jsonString)
         public void AddRange(string jsonString, bool throwIfReservedKey)
         {
             var items = this.jsonToDictionaryDeserializer.Deserialize(jsonString);
-            this.AddRange(items);
+            this.AddRange(items, throwIfReservedKey);
         }
 
         /// <summary>

diff --git a/src/MvcSiteMapProvider/MvcSiteMapProvider/IMvcSiteMapNodeAttribute.cs b/src/MvcSiteMapProvider/MvcSiteMapProvider/IMvcSiteMapNodeAttribute.cs
@@ -191,6 +191,9 @@ public interface IMvcSiteMapNodeAttribute
         /// </summary>
         string Route { get; set; }
 
+        // TODO: In version 5, RouteValues should be a separate property so the values can be controlled separately,
+        // similar to how the DynamicNode values are set.
+
         /// <summary>
         /// Gets or sets the preserved route parameter names (= values that will be used from the current request route).
         /// </summary>