Fixes #278, fixes #181, fixes #9, AuthorizeAttributeAclModule interfe…

…ring with IIS rewrite module. Now using a new instance of HttpContext backed by a null stream instead of using URL rewriting.

src/MvcSiteMapProvider/MvcSiteMapProvider/Security/AuthorizeAttributeAclModule.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Web;
 using System.Web.Mvc;
@@ -55,19 +56,15 @@ IGlobalFilterProvider filterProvider
         /// </returns>
         public bool IsAccessibleToUser(ISiteMap siteMap, ISiteMapNode node)
         {
-            // Clickable? Always accessible.
-            if (node.Clickable == false)
-            {
+            // Not Clickable? Always accessible.
+            if (!node.Clickable)
                 return true;
-            }
 
             var httpContext = mvcContextFactory.CreateHttpContext();
 
             // Is it an external Url?
             if (node.HasExternalUrl(httpContext))
-            {
                 return true;
-            }
 
             return this.VerifyNode(siteMap, node, httpContext);
         }
@@ -84,22 +81,11 @@ protected virtual bool VerifyNode(ISiteMap siteMap, ISiteMapNode node, HttpConte
             if (controllerType == null)
                 return true;
 
-            var originalPath = httpContext.Request.Path;
+            var routes = this.FindRoutesForNode(node, httpContext);
+            if (routes == null)
+                return true; // Static URLs will have no route data, therefore return true.
 
-            // Find routes for the sitemap node's url
-            var routes = this.FindRoutesForNode(node, originalPath, httpContext);
-            try
-            {
-                if (routes == null)
-                    return true; // Static URL's will have no route data, therefore return true.
-
-                return this.VerifyController(node, routes, controllerType);
-            }
-            finally
-            {
-                // Restore HttpContext
-                httpContext.RewritePath(originalPath, true);
-            }
+            return this.VerifyController(node, routes, controllerType);
         }
 
         protected virtual bool VerifyController(ISiteMapNode node, RouteData routes, Type controllerType)
@@ -122,25 +108,33 @@ protected virtual bool VerifyController(ISiteMapNode node, RouteData routes, Typ
             }
         }
 
-        protected virtual RouteData FindRoutesForNode(ISiteMapNode node, string originalPath, HttpContextBase httpContext)
+        protected virtual RouteData FindRoutesForNode(ISiteMapNode node, HttpContextBase httpContext)
         {
-            var routes = mvcContextFactory.GetRoutes();
-            var originalRoutes = routes.GetRouteData(httpContext);
-            var nodeUrl = node.Url;
-            httpContext.RewritePath(nodeUrl, true);
+            // Create a Uri for the current node. Note that we are relying on the 
+            // node.HasExternalUrl(httpContext) check to ensure we don't have an absolute URL.
+            var nodeUri = new Uri(httpContext.Request.Url, node.Url);
+
+            RouteData routeData = null;
 
-            RouteData routeData = node.GetRouteData(httpContext);
-            if (routeData != null)
+            // Create a TextWriter with null stream as a backing stream 
+            // which doesn't consume resources
+            using (var nullWriter = new StreamWriter(Stream.Null))
             {
-                foreach (var routeValue in node.RouteValues)
-                {
-                    routeData.Values[routeValue.Key] = routeValue.Value;
-                }
-                if (originalRoutes != null && (!routeData.Route.Equals(originalRoutes.Route) || originalPath != nodeUrl || node.Area == String.Empty))
+                // Create a new HTTP context using the node's URL instead of the current one.
+                var nodeHttpContext = this.mvcContextFactory.CreateHttpContext(node, nodeUri, nullWriter);
+
+                // Find routes for the sitemap node's URL using the new HTTP context
+                routeData = node.GetRouteData(nodeHttpContext);
+                if (routeData != null)
                 {
-                    routeData.DataTokens.Remove("area");
-                    //routeData.DataTokens.Remove("Namespaces");
-                    //routeData.Values.Remove("area");
+                    foreach (var routeValue in node.RouteValues)
+                    {
+                        routeData.Values[routeValue.Key] = routeValue.Value;
+                    }
+                    if (string.IsNullOrEmpty(node.Area))
+                    {
+                        routeData.DataTokens.Remove("area");
+                    }
                 }
             }
             return routeData;
@@ -293,6 +287,5 @@ protected virtual bool TryCreateController(Type controllerType, out ControllerBa
         }
 
         #endregion
-
     }
-}
+}

src/MvcSiteMapProvider/MvcSiteMapProvider/Web/Mvc/IMvcContextFactory.cs

@@ -1,4 +1,5 @@
 using System;
+using System.IO;
 using System.Web;
 using System.Web.Mvc;
 using System.Web.Routing;
@@ -12,6 +13,7 @@ namespace MvcSiteMapProvider.Web.Mvc
     public interface IMvcContextFactory
     {
         HttpContextBase CreateHttpContext();
+        HttpContextBase CreateHttpContext(ISiteMapNode node, Uri nodeUri, TextWriter writer);
         RequestContext CreateRequestContext(ISiteMapNode node, RouteData routeData);
         RequestContext CreateRequestContext();
         ControllerContext CreateControllerContext(RequestContext requestContext, ControllerBase controller);

src/MvcSiteMapProvider/MvcSiteMapProvider/Web/Mvc/MvcContextFactory.cs

@@ -1,4 +1,5 @@
 using System;
+using System.IO;
 using System.Web;
 using System.Web.UI;
 using System.Web.Mvc;
@@ -26,6 +27,21 @@ protected virtual HttpContextBase CreateHttpContext(ISiteMapNode node)
             return new SiteMapHttpContext(HttpContext.Current, node);
         }
 
+        public virtual HttpContextBase CreateHttpContext(ISiteMapNode node, Uri nodeUri, TextWriter writer)
+        {
+            if (node == null)
+                throw new ArgumentNullException("node");
+            if (nodeUri == null)
+                throw new ArgumentNullException("nodeUri");
+            if (writer == null)
+                throw new ArgumentNullException("writer");
+
+            var request = new HttpRequest(string.Empty, nodeUri.ToString(), nodeUri.Query);
+            var response = new HttpResponse(writer);
+            var httpContext = new HttpContext(request, response);
+            return new SiteMapHttpContext(httpContext, node);
+        }
+
         public virtual RequestContext CreateRequestContext(ISiteMapNode node, RouteData routeData)
         {
             var httpContext = this.CreateHttpContext(node);