Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Build error and warning #10

Merged
merged 4 commits into from
Oct 15, 2024
Merged

fix: Build error and warning #10

merged 4 commits into from
Oct 15, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Fix build error related to change in how sideloaded kits are set on the options object
  • Fix build warning due to use of old reset method

Testing Plan

  • Was this tested locally? If not, explain why.
  • Ran it locally and confirmed sideloaded kit is working now

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 force-pushed the fix/SQDSDKS-6785-fix-build-error-and-warning branch from ed6e75c to 1f2ec69 Compare October 15, 2024 16:09
@einsteinx2 einsteinx2 changed the base branch from main to development October 15, 2024 16:31
@einsteinx2 einsteinx2 merged commit ac3f78b into development Oct 15, 2024
7 of 8 checks passed
@einsteinx2 einsteinx2 deleted the fix/SQDSDKS-6785-fix-build-error-and-warning branch October 15, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@einsteinx2 @BrandonStalnaker