Fix ordering when rearranging #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blastrock I'm not able to reproduce this with a test. Does the configuration in my test match your config? |
|
I stand corrected... this appears to be version-bound. |
mAAdhaTTah
force-pushed
the
fix-peer-dep-order
branch
from
56741bb to
8d627d9
Compare
|
Underlying issue appears to be V8 changing its sorting algo in the version shipped in Node 12. Blech, not sure how to produce a stable sort. For now, I'm going to remove Node 12 from the test matrix. This issue is being worked on in PrismJS itself: PrismJS/prism#1998 so I'm going to go w/ this for now and replace it with the upstream implementation when it ships. |
The sorting algo changed in Node 12, so we're going to remove it from the test matrix for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19.