update roles.yaml #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #52 the operator will now create service accounts based on parameters or Custom Resource names, for that the operator role has to include service account resources.
|
I'll run some tests and update the CSV in your PR so we can launch 0.2.1 ASAP. Have you tested in which env? |
|
I'll merge this one and send another with the other updates in the manifest. Thanks again! |
This was referenced May 15, 2020
|
sorry didn't see the reply during the weekend. I had tested the role in a Openshift 4.3.8 cluster and it seemed to work. Thanks a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a fix for #41 the operator now creates service accounts based on parameters or Custom Resource names. For that behaviour to be correct, the roles have to include the required permissions.