Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to operator-sdk v1.2.0 and go v1.15.x #196

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

LCaparelli
Copy link
Member

@LCaparelli LCaparelli commented Dec 22, 2020

Fix #198, fix #199

Signed-off-by: Lucas Caparelli [email protected]

@LCaparelli LCaparelli added this to the v0.5.0 milestone Dec 22, 2020
@LCaparelli LCaparelli self-assigned this Dec 22, 2020
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why do we need this? 🤔

EDIT: one more thing, is this codegen reflected in the Makefile scripts?

@LCaparelli
Copy link
Member Author

LCaparelli commented Dec 23, 2020

@ricardozanini as you suggested, I'll also upgrade the sdk version. No review required for now, setting this as a draft, thanks!

Looks good, but why do we need this? thinking

EDIT: one more thing, is this codegen reflected in the Makefile scripts?

Yup, just ran make test and this change popped up, none of it is manual.

@LCaparelli LCaparelli added WIP 👷‍♀️ Work In Progress PR enhancement 👑 New feature or request labels Dec 23, 2020
@LCaparelli LCaparelli removed the WIP 👷‍♀️ Work In Progress PR label Dec 24, 2020
@LCaparelli LCaparelli changed the title Regenerate nexus-operator.yaml Upgrade to operator-sdk v1.2.0 and go v1.15.x Dec 24, 2020
@LCaparelli
Copy link
Member Author

@ricardozanini updated the necessary stuff before the release. Since this was already a "pre-release" sort of PR I just used this one, hope you don't mind. Please let me know if you find any problems :-)

@LCaparelli LCaparelli merged commit 9d58f71 into m88i:main Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 👑 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to operator-sdk v1.2.0 Upgrade to Go v1.15.6
2 participants