small fixes #4
Closed
small fixes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts... MegaCli seems to be really picky about where 'Force' and 'adapter' fall.
|
erk, forgot to branch (still new to git) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a typo in remove_ld, rearranged create_ld and remove_ld arguments... MegaCli seems to be really picky about where 'Force' and 'adapter' arguments fall in the command, and wasn't allowing remove_ld or create_ld to be run with the 'force' argument as written.
@m4ce I've tested all the arguments in create_ld and remove_ld, and they seem to be in order now. MegaCli is giving some trouble about the stripe size (nothing less than 64 for me) and hotswap (getting a MC error, not a python error), though, but MC recognizes the command string coming out of megacli-python, so it's probably just my test environment. Worth noting, though probably beyond the scope of the project.