Fix CI errors due to incorrect MSRV #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set minimum rust version to 1.63 due to rayon-core MSRV requirements, and add a matching `rust-version` in the Cargo.toml
This was referenced Nov 5, 2023
Merged
Closed
m4b
reviewed
Nov 5, 2023
| @@ -10,6 +10,7 @@ license = "MIT" | |||
| documentation = "https://docs.rs/scroll" | |||
| description = "A suite of powerful, extensible, generic, endian-aware Read/Write traits for byte buffers" | |||
| include = ["src/**/*", "Cargo.toml", "LICENSE", "README.md"] | |||
| rust-version = "1.63" | |||
There was a problem hiding this comment.
argh actually i didn't want to bump the msrv here because we don't have an actual requirement in scroll itself (only the dev deps)
Frostie314159
pushed a commit
to Frostie314159/scroll
that referenced
this pull request
Nov 7, 2023
* Set minimum rust version to 1.63 due to rayon-core MSRV requirements, and add a matching `rust-version` in the Cargo.toml
Frostie314159
pushed a commit
to Frostie314159/scroll
that referenced
this pull request
Nov 20, 2023
* Set minimum rust version to 1.63 due to rayon-core MSRV requirements, and add a matching `rust-version` in the Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-versionin the Cargo.toml