fix some clippy warnings #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4b
reviewed
Oct 7, 2018
| } | ||
|
|
||
| /// Reads `Self` from `This` using the context `Ctx`; must _not_ fail | ||
| pub trait FromCtx<Ctx: Copy = (), This: ?Sized = [u8]> { | ||
| #[inline] |
There was a problem hiding this comment.
What is the rationale for removing inline annotation here? Does it have no effect when it's on the trait def? (I've always wondered actually).
Otherwise, we def should have inline, as perf goes down pretty significantly without it
There was a problem hiding this comment.
Inline annotations are only effective on impls.
|
Awesome good to know, thanks for this ! |
m4b
approved these changes
Oct 8, 2018
|
You're welcome. |
willglynn
pushed a commit
to willglynn/scroll
that referenced
this pull request
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.