Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwrite deriving fails with "unparseable tokens" with struct containing lifetimes? #83

Closed
RaitoBezarius opened this issue May 1, 2023 · 6 comments · Fixed by #101
Closed

Comments

@RaitoBezarius
Copy link
Contributor

RaitoBezarius commented May 1, 2023

Consider this structure:

#[derive(Pwrite)]
pub struct SymbolTable<'a> {
    symbols: &'a [u8],
}

(extracted from Goblin codebase)

This induces proc-macro derive produced unparseable tokens, on rustc 1.68.1.

I don't know what happens here.

@m4b
Copy link
Owner

m4b commented May 1, 2023

That’s not good :/ must be something wrong with the scroll pwrite derive macro…

@Frostie314159
Copy link
Contributor

I'm currently working on fixing that and cleaning up some of the derive code.

@m4b
Copy link
Owner

m4b commented Jan 1, 2024

Would love if we got this fixed, @Frostie314159 did you manage to take a look at this? (I know you were working on other things, and thank you, just doing triage here)

@Frostie314159
Copy link
Contributor

Yeah, I looked at the macro code and it's all a bit confusing, I couldn't work on this since I was busy with the 37c3, but maybe I can get back to this soon.

@m4b
Copy link
Owner

m4b commented Jan 1, 2024

sounds good no rush, and if you don't feel like working on it, that's ok too :) anyway 0.12 scroll is out

@Frostie314159
Copy link
Contributor

That's good to hear, btw happy new year from germany.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants