Upgrade to 2018 edition (#49)

* cargo +nightly fix --edition --edition-idioms
* Upgrade `scroll_derive` to 2018 edition
* Remove build.rs script

Cargo.toml

@@ -3,6 +3,7 @@ name = "scroll"
 version = "0.10.0"
 authors = ["m4b <[email protected]>", "Ted Mielczarek <[email protected]>"]
 readme = "README.md"
+edition = "2018"
 keywords = ["bytes", "endian", "immutable", "pread", "pwrite"]
 repository = "https://github.com/m4b/scroll"
 license = "MIT"

benches/bench.rs

@@ -1,11 +1,7 @@
 #![feature(test)]
 extern crate test;
-extern crate byteorder;
-extern crate scroll;
-extern crate rayon;
-//extern crate byteio;
 
-use scroll::{Cread, Cwrite, Pread, Pwrite, IOread, IOwrite, LE};
+use scroll::{Cread, Pread, LE};
 use test::black_box;
 
 #[bench]

examples/data_ctx.rs

@@ -1,5 +1,3 @@
-extern crate scroll;
-
 use scroll::{ctx, Endian, Pread, BE};
 
 #[derive(Debug)]

scroll_derive/Cargo.toml

@@ -3,6 +3,7 @@ name = "scroll_derive"
 version = "0.10.0"
 authors = ["m4b <[email protected]>", "Ted Mielczarek <[email protected]>"]
 readme = "README.md"
+edition = "2018"
 keywords = ["derive", "macros", "pread", "pwrite", "bytes"]
 repository = "https://github.com/m4b/scroll_derive"
 license = "MIT"

scroll_derive/examples/main.rs

@@ -1,6 +1,4 @@
-extern crate scroll;
-#[macro_use]
-extern crate scroll_derive;
+use scroll_derive::{Pread, Pwrite, IOread, IOwrite, SizeWith};
 
 #[derive(Debug, PartialEq, Pread, Pwrite, IOread, IOwrite, SizeWith)]
 #[repr(C)]

scroll_derive/src/lib.rs

@@ -2,9 +2,7 @@
 
 extern crate proc_macro;
 extern crate proc_macro2;
-#[macro_use]
-extern crate quote;
-extern crate syn;
+use quote::quote;
 
 use proc_macro::TokenStream;
 
@@ -31,7 +29,7 @@ fn impl_struct(name: &syn::Ident, fields: &syn::FieldsNamed) -> proc_macro2::Tok
             }
         }
     }).collect();
-    
+
     quote! {
         impl<'a> ::scroll::ctx::TryFromCtx<'a, ::scroll::Endian> for #name where #name: 'a {
             type Error = ::scroll::Error;
@@ -89,7 +87,7 @@ fn impl_try_into_ctx(name: &syn::Ident, fields: &syn::FieldsNamed) -> proc_macro
             }
         }
     }).collect();
-    
+
     quote! {
         impl<'a> ::scroll::ctx::TryIntoCtx<::scroll::Endian> for &'a #name {
             type Error = ::scroll::Error;

scroll_derive/tests/tests.rs

@@ -1,15 +1,14 @@
-extern crate scroll;
-#[macro_use]
-extern crate scroll_derive;
+use scroll_derive::{Pread, Pwrite, SizeWith, IOread, IOwrite};
+use scroll::{Pread, Pwrite, Cread, Cwrite, LE};
+
+use scroll::ctx::SizeWith;
 
 #[derive(Debug, PartialEq, Pread, Pwrite)]
 struct Data {
   id: u32,
   timestamp: f64,
 }
 
-use scroll::{Pread, Pwrite, Cread, Cwrite, LE};
-use scroll::ctx::SizeWith;
 
 #[test]
 fn test_data (){

src/ctx.rs

@@ -52,8 +52,8 @@ use core::result;
 #[cfg(feature = "std")]
 use std::ffi::{CStr, CString};
 
-use error;
-use endian::Endian;
+use crate::error;
+use crate::endian::Endian;
 
 /// A trait for measuring how large something is; for a byte sequence, it will be its length.
 pub trait MeasureWith<Ctx> {
@@ -128,13 +128,13 @@ pub trait TryFromCtx<'a, Ctx: Copy = (), This: ?Sized = [u8]> where Self: 'a + S
 
 /// Writes `Self` into `This` using the context `Ctx`
 pub trait IntoCtx<Ctx: Copy = (), This: ?Sized = [u8]>: Sized {
-    fn into_ctx(self, &mut This, ctx: Ctx);
+    fn into_ctx(self, _: &mut This, ctx: Ctx);
 }
 
 /// Tries to write `Self` into `This` using the context `Ctx`
 pub trait TryIntoCtx<Ctx: Copy = (), This: ?Sized = [u8]>: Sized {
     type Error;
-    fn try_into_ctx(self, &mut This, ctx: Ctx) -> Result<usize, Self::Error>;
+    fn try_into_ctx(self, _: &mut This, ctx: Ctx) -> Result<usize, Self::Error>;
 }
 
 /// Gets the size of `Self` with a `Ctx`, and in `Self::Units`. Implementors can then call `Gread` related functions
@@ -279,9 +279,7 @@ ctx_impl!(u32, 4);
 ctx_impl!(i32, 4);
 ctx_impl!(u64, 8);
 ctx_impl!(i64, 8);
-#[cfg(rust_1_26)]
 ctx_impl!(u128, 16);
-#[cfg(rust_1_26)]
 ctx_impl!(i128, 16);
 
 macro_rules! from_ctx_float_impl {
@@ -325,9 +323,7 @@ into_ctx_impl!(u32, 4);
 into_ctx_impl!(i32, 4);
 into_ctx_impl!(u64, 8);
 into_ctx_impl!(i64, 8);
-#[cfg(rust_1_26)]
 into_ctx_impl!(u128, 16);
-#[cfg(rust_1_26)]
 into_ctx_impl!(i128, 16);
 
 macro_rules! into_ctx_float_impl {
@@ -458,9 +454,7 @@ sizeof_impl!(u32);
 sizeof_impl!(i32);
 sizeof_impl!(u64);
 sizeof_impl!(i64);
-#[cfg(rust_1_26)]
 sizeof_impl!(u128);
-#[cfg(rust_1_26)]
 sizeof_impl!(i128);
 sizeof_impl!(f32);
 sizeof_impl!(f64);

src/greater.rs

@@ -1,6 +1,6 @@
 use core::ops::{Index, IndexMut, RangeFrom};
 
-use ctx::{FromCtx, IntoCtx};
+use crate::ctx::{FromCtx, IntoCtx};
 
 /// Core-read - core, no_std friendly trait for reading basic traits from byte buffers. Cannot fail unless the buffer is too small, in which case an assert fires and the program panics.
 ///

src/leb128.rs

@@ -1,9 +1,9 @@
 use core::u8;
 use core::convert::{From, AsRef};
 use core::result;
-use Pread;
-use ctx::TryFromCtx;
-use error;
+use crate::Pread;
+use crate::ctx::TryFromCtx;
+use crate::error;
 
 #[derive(Debug, PartialEq, Copy, Clone)]
 /// An unsigned leb128 integer
@@ -56,7 +56,7 @@ impl Sleb128 {
     #[inline]
     /// Read a variable length i64 from `bytes` at `offset`
     pub fn read(bytes: &[u8], offset: &mut usize) -> error::Result<i64> {
-        use Pread;
+        use crate::Pread;
         let tmp = bytes.pread::<Sleb128>(*offset)?;
         *offset += tmp.size();
         Ok(tmp.into())
@@ -95,7 +95,7 @@ impl<'a> TryFromCtx<'a> for Uleb128 {
     type Error = error::Error;
     #[inline]
     fn try_from_ctx(src: &'a [u8], _ctx: ()) -> result::Result<(Self, usize), Self::Error> {
-        use pread::Pread;
+        use crate::pread::Pread;
         let mut result = 0;
         let mut shift = 0;
         let mut count = 0;

src/lesser.rs

@@ -1,5 +1,5 @@
 use std::io::{Result, Read, Write};
-use ctx::{FromCtx, IntoCtx, SizeWith};
+use crate::ctx::{FromCtx, IntoCtx, SizeWith};
 
 /// An extension trait to `std::io::Read` streams; this only deserializes simple types, like `u8`, `i32`, `f32`, `usize`, etc.
 ///

src/lib.rs

@@ -102,18 +102,18 @@
 //!
 //! For example, suppose we have a datatype and we want to specify how to parse or serialize this datatype out of some arbitrary
 //! byte buffer. In order to do this, we need to provide a [TryFromCtx](trait.TryFromCtx.html) impl for our datatype.
-//! 
+//!
 //! In particular, if we do this for the `[u8]` target, using the convention `(usize, YourCtx)`, you will automatically get access to
 //! calling `pread_with::<YourDatatype>` on arrays of bytes.
-//! 
+//!
 //! ```rust
 //! use scroll::{self, ctx, Pread, BE, Endian};
-//! 
+//!
 //! struct Data<'a> {
 //!   name: &'a str,
 //!   id: u32,
 //! }
-//! 
+//!
 //! // note the lifetime specified here
 //! impl<'a> ctx::TryFromCtx<'a, Endian> for Data<'a> {
 //!   type Error = scroll::Error;
@@ -126,7 +126,7 @@
 //!     Ok((Data { name: name, id: id }, *offset))
 //!   }
 //! }
-//! 
+//!
 //! let bytes = b"UserName\x00\x01\x02\x03\x04";
 //! let data = bytes.pread_with::<Data>(0, BE).unwrap();
 //! assert_eq!(data.id, 0x01020304);
@@ -139,12 +139,7 @@
 
 #[cfg(feature = "derive")]
 #[allow(unused_imports)]
-#[macro_use]
-extern crate scroll_derive;
-
-#[cfg(feature = "derive")]
-#[doc(hidden)]
-pub use scroll_derive::*;
+use scroll_derive::{Pread, Pwrite, SizeWith, IOread, IOwrite};
 
 #[cfg(feature = "std")]
 extern crate core;
@@ -159,14 +154,14 @@ mod leb128;
 #[cfg(feature = "std")]
 mod lesser;
 
-pub use endian::*;
-pub use pread::*;
-pub use pwrite::*;
-pub use greater::*;
-pub use error::*;
-pub use leb128::*;
+pub use crate::endian::*;
+pub use crate::pread::*;
+pub use crate::pwrite::*;
+pub use crate::greater::*;
+pub use crate::error::*;
+pub use crate::leb128::*;
 #[cfg(feature = "std")]
-pub use lesser::*;
+pub use crate::lesser::*;
 
 #[doc(hidden)]
 pub mod export {

src/pread.rs

@@ -1,8 +1,8 @@
 use core::result;
 use core::ops::{Index, RangeFrom};
 
-use ctx::{TryFromCtx, MeasureWith};
-use error;
+use crate::ctx::{TryFromCtx, MeasureWith};
+use crate::error;
 
 /// A very generic, contextual pread interface in Rust. Allows completely parallelized reads, as `Self` is immutable
 ///

src/pwrite.rs

@@ -1,8 +1,8 @@
 use core::result;
 use core::ops::{Index, IndexMut, RangeFrom};
 
-use ctx::{TryIntoCtx, MeasureWith};
-use error;
+use crate::ctx::{TryIntoCtx, MeasureWith};
+use crate::error;
 
 /// Writes into `Self` at an offset of type `I` using a `Ctx`
 ///