Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Update k8s.io/kube-openapi dependency #304

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

jeromefroe
Copy link
Collaborator

This commit updates our dependency on k8s.io/kube-openapi. In a recent commit, the package made a breaking change to the OpenAPIDefinition type but since the package doesn't use tagged releases, the Go toolchain has trouble including the package when a module has a transitive dependency on different versions of the package. By updating to the latest commit we can ensure that as long as packages of the m3db-operator can update their other dependencies to the latest version as well then the latest version will work for the package.

@jeromefroe jeromefroe requested a review from schallert October 20, 2021 20:12
@jeromefroe jeromefroe force-pushed the jerome/update-kube-openapi-dependency branch from 6792aa1 to aec2115 Compare October 21, 2021 16:39
@jeromefroe jeromefroe changed the base branch from master to jerome/update-to-go-16 October 21, 2021 16:40
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #304 (8cd79a5) into master (d706132) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   76.04%   76.04%           
=======================================
  Files          32       32           
  Lines        2571     2571           
=======================================
  Hits         1955     1955           
  Misses        437      437           
  Partials      179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d706132...8cd79a5. Read the comment docs.

Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from jerome/update-to-go-16 to master October 21, 2021 17:34
@jeromefroe jeromefroe force-pushed the jerome/update-kube-openapi-dependency branch from aec2115 to 8cd79a5 Compare October 21, 2021 17:36
@jeromefroe jeromefroe merged commit b183d3b into master Oct 21, 2021
@jeromefroe jeromefroe deleted the jerome/update-kube-openapi-dependency branch October 21, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants