Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility when using the original update annoation with an OnDelete update strategy #284

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

nbroyles
Copy link
Collaborator

Thanks for contributing to the M3DB Operator! We'd love to accept your contribution, but we require that most issues
outside of trivial changes such as typo corrections have an issue associated with the pull request. So please open an
issue
first!

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #284 (30899e0) into master (8972589) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   76.09%   76.11%   +0.01%     
==========================================
  Files          32       32              
  Lines        2548     2550       +2     
==========================================
+ Hits         1939     1941       +2     
  Misses        430      430              
  Partials      179      179              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8972589...30899e0. Read the comment docs.

@nbroyles nbroyles merged commit 5d3e770 into master Mar 16, 2021
@nbroyles nbroyles deleted the nb/back-compat branch March 16, 2021 18:20
soundvibe added a commit that referenced this pull request Apr 1, 2021
* master:
  Backwards compatibility when using the original update annoation with an OnDelete update strategy (#284)
  Add support for parallel node updates within a statefulset (#283)
  Support namespace ExtendedOptions in cluster spec (#282)
  [controller] Support multi instance placement add (#275)
  [gomod] Update M3DB dependency (#277)
  [cmd] Fix instrument package name (#280)

# Conflicts:
#	pkg/k8sops/annotations/annotations.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants