[ci] Update kind; fix node image #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make test manifests work better out of the box with kind.
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 76.10% 76.01% -0.09%
==========================================
Files 32 32
Lines 2381 2381
==========================================
- Hits 1812 1810 -2
- Misses 426 427 +1
- Partials 143 144 +1 Continue to review full report at Codecov.
|
wesleyk
approved these changes
Feb 25, 2021
wesleyk
reviewed
Feb 25, 2021
| @@ -0,0 +1,103 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
is this etcd kind example sourced from somewhere? Could we link the source if so?
There was a problem hiding this comment.
It's our own thing. We have some static manifests for etcd in this directory, and I just took those and added a storageclass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make test manifests work better out of the box with kind.