Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding sidecar containers #253

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

jeromefroe
Copy link
Collaborator

This commit adds support to the operator for adding sidecar containers to the pods that run the M3DB nodes.

@jeromefroe jeromefroe requested a review from schallert December 4, 2020 21:09
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #253 (f685777) into master (32f88b4) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   76.16%   76.22%   +0.06%     
==========================================
  Files          30       30              
  Lines        2240     2246       +6     
==========================================
+ Hits         1706     1712       +6     
  Misses        393      393              
  Partials      141      141              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f88b4...f685777. Read the comment docs.

Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That was easy!

@jeromefroe jeromefroe merged commit 2361ffe into master Dec 7, 2020
@jeromefroe jeromefroe deleted the jerome/add-support-for-adding-sidecars branch December 7, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants