Allow AggregationOptions to be set for a namespace #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 76.29% 76.16% -0.14%
==========================================
Files 30 30
Lines 2215 2240 +25
==========================================
+ Hits 1690 1706 +16
- Misses 388 393 +5
- Partials 137 141 +4 Continue to review full report at Codecov.
|
jeromefroe
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
LGTM, @schallert is much more familiar with the codebase than I am though so would be good to get his OK too if there's no rush
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AggregationOptions is a new field on NamespaceOptions that allows us to set aggregation details on the namespace definition itself. This is useful for the coordinator when resolving namespaces dynamically instead of via static configuration. This PR allows those same options to be set in the cluster spec.