[controller] Always remove update annotation after processing StatefulSet #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 76.22% 76.44% +0.21%
==========================================
Files 30 30
Lines 2162 2165 +3
==========================================
+ Hits 1648 1655 +7
+ Misses 381 377 -4
Partials 133 133 Continue to review full report at Codecov.
|
schallert
approved these changes
Sep 30, 2020
jeromefroe
force-pushed
the
jerome/controller/always-remove-update-annotation
branch
from
bc1d77a to
7ed9d21
Compare
jeromefroe
deleted the
jerome/controller/always-remove-update-annotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the controller to always remove the update annotation after processing a StatefulSet, even if the controller doesn't need to change the StatefulSet's spec. This will ensure that a user, after setting the annotation, can always know if the operator has processed a StatefulSet by checking if the annotation has been removed or not.