[spec] Break ext coord into separate config #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan on adding more ways of looking up an external coordinator than just a selector. Allow the external config to be expanded later on.
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 75.52% 75.33% -0.19%
==========================================
Files 30 30
Lines 2112 2112
==========================================
- Hits 1595 1591 -4
- Misses 391 393 +2
- Partials 126 128 +2 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan on adding more ways of looking up an external coordinator than
just a selector. Allow the external config to be expanded later on.