[k8sops] Ensure dbnodes in DNS when bootstrapping #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Kubernetes will not generate DNS names for a pod if it's not ready. This sets `publishNotReadyAddresses` on the M3DB service so that we can look up pod IPs even when they're bootstrapping (and thus send them writes to be buffered to commitlog).
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 75.27% 75.28% +0.01%
==========================================
Files 30 30
Lines 2095 2096 +1
==========================================
+ Hits 1577 1578 +1
Misses 391 391
Partials 127 127 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Kubernetes will not generate DNS names for a pod if it's not
ready. This sets
publishNotReadyAddresseson the M3DB service so thatwe can look up pod IPs even when they're bootstrapping (and thus send
them writes to be buffered to commitlog).