Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Support custom env vars in cluster spec #194

Merged
merged 2 commits into from
Feb 13, 2020
Merged

[api] Support custom env vars in cluster spec #194

merged 2 commits into from
Feb 13, 2020

Conversation

schallert
Copy link
Collaborator

Fixes #182.

@schallert schallert marked this pull request as ready for review February 13, 2020 16:39
@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #194 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   75.14%   75.17%   +0.03%     
==========================================
  Files          30       30              
  Lines        2084     2087       +3     
==========================================
+ Hits         1566     1569       +3     
  Misses        391      391              
  Partials      127      127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea6eab...3b02645. Read the comment docs.

robskillington
robskillington approved these changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schallert schallert merged commit c3c916a into master Feb 13, 2020
@schallert schallert deleted the schallert/custom_env_vars branch February 13, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robskillington robskillington robskillington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom environment variables in cluster spec
2 participants
@schallert @robskillington