Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify and set base annotations for operator resources #155

Merged
merged 4 commits into from
Jun 20, 2019

Conversation

robskillington
Copy link
Collaborator

A few people are using annotations for configuring their pod monitoring, this will help them specify what annotations to add so they can monitor their instances.

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #155 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   74.86%   75.02%   +0.15%     
==========================================
  Files          26       27       +1     
  Lines        1898     1910      +12     
==========================================
+ Hits         1421     1433      +12     
  Misses        364      364              
  Partials      113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab71b07...aab9e4e. Read the comment docs.

@robskillington robskillington requested a review from schallert June 20, 2019 01:28
@schallert schallert force-pushed the r/add-annotations-configuration branch from 6c2055c to aab9e4e Compare June 20, 2019 04:32
Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schallert schallert merged commit a57e8a9 into master Jun 20, 2019
@schallert schallert deleted the r/add-annotations-configuration branch June 20, 2019 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants